Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: SIGBUS in go/types in TestVet #71391

Open
gopherbot opened this issue Jan 22, 2025 · 5 comments
Open

runtime: SIGBUS in go/types in TestVet #71391

gopherbot opened this issue Jan 22, 2025 · 5 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "cmd/vet" && test == "TestVet/method"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestVet/method
=== PAUSE TestVet/method
=== CONT  TestVet/method
    vet_test.go:195: error check failed: 
        Unmatched Errors:
        unexpected fault address 0x10769e80
        fatal error: fault
        [signal SIGBUS: bus error code=0x2 addr=0x10769e80 pc=0x10769e80]
        goroutine 1 gp=0xc000002380 m=2 mp=0xc00004c808 [running]:
        runtime.throw({0x10663d90?, 0x28?})
...
        	../../runtime/proc.go:435 +0xce fp=0xc000043f38 sp=0xc000043f18 pc=0x1038d26e
        runtime.gcBgMarkWorker(0xc0000ca620)
        	../../runtime/mgc.go:1423 +0xe9 fp=0xc000043fc8 sp=0xc000043f38 pc=0x10339389
        runtime.gcBgMarkStartWorkers.gowrap1()
        	../../runtime/mgc.go:1339 +0x25 fp=0xc000043fe0 sp=0xc000043fc8 pc=0x10339265
        runtime.goexit({})
        	../../runtime/asm_amd64.s:1700 +0x1 fp=0xc000043fe8 sp=0xc000043fe0 pc=0x10394601
        created by runtime.gcBgMarkStartWorkers in goroutine 1
        	../../runtime/mgc.go:1339 +0x105
--- FAIL: TestVet/method (4.09s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 22, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "cmd/vet" && test == "TestVet/method"
2025-01-22 16:03 gotip-darwin-amd64_14 go@70b603f4 cmd/vet.TestVet/method (log)
=== RUN   TestVet/method
=== PAUSE TestVet/method
=== CONT  TestVet/method
    vet_test.go:195: error check failed: 
        Unmatched Errors:
        unexpected fault address 0x10769e80
        fatal error: fault
        [signal SIGBUS: bus error code=0x2 addr=0x10769e80 pc=0x10769e80]
        goroutine 1 gp=0xc000002380 m=2 mp=0xc00004c808 [running]:
        runtime.throw({0x10663d90?, 0x28?})
...
        	../../runtime/proc.go:435 +0xce fp=0xc000043f38 sp=0xc000043f18 pc=0x1038d26e
        runtime.gcBgMarkWorker(0xc0000ca620)
        	../../runtime/mgc.go:1423 +0xe9 fp=0xc000043fc8 sp=0xc000043f38 pc=0x10339389
        runtime.gcBgMarkStartWorkers.gowrap1()
        	../../runtime/mgc.go:1339 +0x25 fp=0xc000043fe0 sp=0xc000043fc8 pc=0x10339265
        runtime.goexit({})
        	../../runtime/asm_amd64.s:1700 +0x1 fp=0xc000043fe8 sp=0xc000043fe0 pc=0x10394601
        created by runtime.gcBgMarkStartWorkers in goroutine 1
        	../../runtime/mgc.go:1339 +0x105
--- FAIL: TestVet/method (4.09s)

watchflakes

@adonovan adonovan self-assigned this Jan 22, 2025
@adonovan adonovan changed the title cmd/vet: TestVet/method failures cmd/vet: SIGBUS in go/types in TestVet while preparing call to panic Jan 22, 2025
@adonovan
Copy link
Member

adonovan commented Jan 22, 2025

The SIGBUS occurs on this line:

		panic(fmt.Sprintf("%s: unknown expression type %T", check.fset.Position(e.Pos()), e))

The addresses are properly aligned. I can't correlate the program counter to a valid instruction in the disassembly of this amd64 executable though.

@adonovan adonovan changed the title cmd/vet: SIGBUS in go/types in TestVet while preparing call to panic runtime: SIGBUS in go/types in TestVet Jan 22, 2025
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jan 22, 2025
@adonovan
Copy link
Member

The second stack implicates a different line:

				d.pred.add(n)

Either way, this is a sign of memory corruption or a code generation bug.

@adonovan adonovan removed their assignment Jan 22, 2025
@adonovan adonovan marked this as a duplicate of #71394 Jan 24, 2025
@mknyszek
Copy link
Contributor

This might be an issue with this particular Darwin machine, we've seen other bugs filed by watchflakes that look like it's an issue with some of our fleet. This might be similar.

@mknyszek
Copy link
Contributor

This is actually exactly the same machine we saw earlier! #71300

@mknyszek mknyszek added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jan 29, 2025
@mknyszek mknyszek added this to the Backlog milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
Status: No status
Development

No branches or pull requests

3 participants