Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: crashes due to apparent data race(s) #71425

Open
findleyr opened this issue Jan 24, 2025 · 1 comment
Open

x/tools/gopls: crashes due to apparent data race(s) #71425

findleyr opened this issue Jan 24, 2025 · 1 comment
Labels
BugReport Issues describing a possible bug in the Go implementation. gopls/telemetry-wins gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Member

findleyr commented Jan 24, 2025

While we've found and fixed many gopls crashes thanks to telemetry, as we gain more users it appears we're accumulating a long tail of issues that "can't happen" based on easily verifiable local invariants.

In some cases, these were related to misreporting of stacks by the runtime (#70637), but others cannot be explained by a misreported stack, and indicate some form of memory corruption or (most likely) data race.

This issue is an umbrella for those bugs. @adonovan and I will consolidate them here.

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 24, 2025
@gopherbot gopherbot added this to the Unreleased milestone Jan 24, 2025
@gabyhelp
Copy link

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugReport Issues describing a possible bug in the Go implementation. gopls/telemetry-wins gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants