Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link/internal: panic in loader.(*SymbolBuilder).SetBytesAt #71426

Closed
gopherbot opened this issue Jan 24, 2025 · 3 comments
Closed

cmd/link/internal: panic in loader.(*SymbolBuilder).SetBytesAt #71426

gopherbot opened this issue Jan 24, 2025 · 3 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/template" && test == ""

Issue created automatically to collect these failures.

Example (log):

FAIL	golang.org/x/tools/gopls/internal/test/integration/template [build failed]

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 24, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/template" && test == ""
2025-01-24 01:06 x_tools-go1.22-darwin-amd64-race tools@45227b6d release-branch.go1.22@c3c6a500 x/tools/gopls/internal/test/integration/template (log)
FAIL	golang.org/x/tools/gopls/internal/test/integration/template [build failed]

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 24, 2025
@gopherbot gopherbot added this to the Unreleased milestone Jan 24, 2025
@adonovan
Copy link
Member

# golang.org/x/tools/gopls/internal/test/integration/template.test
panic: attempt to write past end of buffer

goroutine 102 [running]:
cmd/link/internal/loader.(*SymbolBuilder).SetBytesAt(...)
	cmd/link/internal/loader/symbolbuilder.go:340
cmd/link/internal/ld.(*pclntab).generatePctab.func2(0xa2405a0?, 0x98ea0?)
	cmd/link/internal/ld/pcln.go:507 +0x14e
cmd/link/internal/ld.writeBlock(0xc0000da400, 0xc0000d4690, 0xc000484008, {0xc001dc81b8, 0x1a90, 0x0?}, 0x0?, 0x0?, {0xa44afc0, 0x200, ...})
	cmd/link/internal/ld/data.go:1095 +0x484
cmd/link/internal/ld.writeBlocks.func1(0xa449fa0?, 0x0?, {0xc001dc81b8?, 0x9f5cdfb?, 0xf?}, 0xc001af2090?, 0xc0000b1408?, {0xa44afc0, 0x200, 0x200})
	cmd/link/internal/ld/data.go:1048 +0x70
created by cmd/link/internal/ld.writeBlocks in goroutine 65
	cmd/link/internal/ld/data.go:1047 +0x53b

@adonovan adonovan changed the title x/tools/gopls/internal/test/integration/template: unrecognized failures cmd/link/internal: panic in loader.(*SymbolBuilder).SetBytesAt Jan 24, 2025
@adonovan adonovan added compiler/runtime Issues related to the Go compiler and/or runtime. and removed gopls Issues related to the Go language server, gopls. labels Jan 24, 2025
@mknyszek
Copy link
Contributor

mknyszek commented Feb 5, 2025

This failure implicates the same Darwin machine that was causing issues at the time. It's no longer in the pool, so I think there's nothing to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

3 participants