-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: very long names for simple generic usage #71535
Comments
Note that the actual code uses an interface, not that long literal.
Since the Value interface mentions Value itself, basically no one is ever going to write that literal accidentally, so there is arguably no reason to expand Value into the long literal. In the case where the argument is a named interface that mentions itself, or a named interface with more than N methods, it seems like it would be better to just use the interface name, so that these would show up in the code as
That's still longer than one would hope, but far shorter than the current symbol names. |
Another example of the long names showing up in an unwanted place: race detector reports.
|
Related to #60324. |
also related? #50438 |
Go version
go1.23.5, go1.24rc2
Output of
go env
in your module/workspace:What did you do?
Build a program using a few TransientSlice[Value].
Profile it, showing hot symbols.
Run nm to see symbols.
What did you see happen?
Unexpectedly long symbol names, like in the comically large and unreadable boxes in this profile:
Or in this nm output:
What did you expect to see?
Reasonably short symbol names, and normal-sized pprof boxes.
The text was updated successfully, but these errors were encountered: