Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/trace: TestTraceCgoCallback/Default fails on new freebsd-amd64-race LUCI builder with FreeBSD 14.1 #71556

Open
dmitshur opened this issue Feb 4, 2025 · 2 comments
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD RaceDetector
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Feb 4, 2025

Running this test on a new LUCI builder configuration that sets the -race flag on FreeBSD 14.1 fails with:

# GOOS=freebsd GOARCH=amd64 go test -race -run=^TestTraceCgoCallback$ internal/trace
--- FAIL: TestTraceCgoCallback (1.04s)
--- FAIL: TestTraceCgoCallback/Default (1.02s)
    reader_test.go:100: unexpected error while reading the trace: bad file format: not a Go execution trace?
    trace_test.go:627: found bad trace; dumping to test log...
    trace_test.go:628: dumping trace: bad file format: not a Go execution trace?
FAIL
FAIL	internal/trace	50.965s

It's the only test that fails, so I'll add a temporary skip to let the builder be added without needing a known issue. Filing this issue to track the next steps of investigating and resolving this.

CC @golang/freebsd.

@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD RaceDetector labels Feb 4, 2025
@dmitshur dmitshur added this to the Go1.25 milestone Feb 4, 2025
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 4, 2025
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/646396 mentions this issue: internal/trace: skip TestTraceCgoCallback on freebsd-amd64-race builders

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/646136 mentions this issue: main.star: add freebsd-amd64-race

@mknyszek mknyszek self-assigned this Feb 5, 2025
gopherbot pushed a commit to golang/build that referenced this issue Feb 5, 2025
Move the remaining freebsd-amd64 builder configuration from old infra,
and then stop it there (CL 646515).

For golang/go#61095.
For golang/go#71556.

Change-Id: I5b12e139458f7ee9ff97061d23d27fe47ee9937e
Reviewed-on: https://go-review.googlesource.com/c/build/+/646136
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit that referenced this issue Feb 5, 2025
For #71556.

Change-Id: I754f113bfdad244d0e978cf559bf45f2f4d7bf06
Reviewed-on: https://go-review.googlesource.com/c/go/+/646396
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD RaceDetector
Projects
Development

No branches or pull requests

3 participants