x/tools/gopls: SEGV while clearing memory in newobject

[adonovan]

#!stacks
"runtime.sigpanic:+3" && "runtime.memclrNoHeapPointers:+172" && "runtime.mallocgc" && "runtime.newobject:+1"

Issue created by stacks.

Possibly another manifestation of #71425?
Telemetry blames the RET instruction. Can it be? That's a read from the stack, but there's no way a rogue write to memory could clobber this thread's SP register.

This stack FpcsIw was reported by telemetry:

• crash/crash
• runtime.throw:+9
• runtime.sigpanic:+3
• runtime.memclrNoHeapPointers:+172
• runtime.mallocgc:+182
• runtime.newobject:+1
• golang.org/x/tools/internal/event/label.Label.Format:+7
• golang.org/x/tools/internal/event/label.(*Label).Format:+0
• fmt.(*pp).handleMethods:+19
• fmt.(*pp).printValue:+4
• fmt.(*pp).printValue:+144
• fmt.(*pp).printArg:+78
• fmt.(*pp).doPrint:+8
• fmt.Sprint:+2
• golang.org/x/tools/internal/event/export/metric.labelListLess:+2
• golang.org/x/tools/internal/event/export/metric.getGroup.func1:+1
• sort.Search:+7

golang.org/x/tools/gopls@v0.17.1 go1.23.4 darwin/amd64 vscode (1)

[gabyhelp]

Related Issues

• runtime: SEGV in mapaccess2 (go1.23.2 darwin/amd64) #71123
• x/tools/gopls: OOM reported by fatal in runtime.mallocgc (windows) #70445 (closed)
• x/tools/gopls: out-of-memory failure on Windows #71065
• x/tools/gopls: analysisinternal.ZeroValue crash on (presumably) unsafe.Pointer #70585 (closed)
• x/tools/gopls: out of memory (crash) #42889 (closed)
• gopls SEGV fault on startup. #70271 (closed)
• x/tools/gopls: crash in Hover (telemetry) #69362
• x/tools/gopls: crash in testFuncs with *error argument #70927 (closed)
• x/tools/gopls: sigpanic in persistent.(*mapNode).forEach #71115
• x/tools/gopls: automated issue report (crash) #40449 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}