Skip to content

x/tools/gopls/internal/cmd: TestDefinition failures #71626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gopherbot opened this issue Feb 8, 2025 · 2 comments
Closed

x/tools/gopls/internal/cmd: TestDefinition failures #71626

gopherbot opened this issue Feb 8, 2025 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestDefinition"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestDefinition
=== PAUSE TestDefinition
=== CONT  TestDefinition
    integration_test.go:269: gopls definition a.go:7:2: exited with code -1, want success: true (gopls definition a.go:7:2: exit=-1 stdout=<<>> stderr=<<fork/exec /home/swarming/.swarming/w/ir/x/t/go-build1982600917/b729/cmd.test: bad address>>)
    integration_test.go:270: gopls definition a.go:7:2: stdout does not match [a.go:3:6-7: defined here as func f]; got <<>>
    integration_test.go:276: gopls definition a.go:4:7: stdout does not match [print.go.* defined here as func fmt.Println]; got <<>>
    integration_test.go:277: gopls definition a.go:4:7: stdout does not match [Println formats using the default formats for its operands]; got <<>>
--- FAIL: TestDefinition (11.56s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 8, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestDefinition"
2025-02-07 16:33 x_tools-go1.22-netbsd-arm tools@4d1de705 release-branch.go1.22@5817e650 x/tools/gopls/internal/cmd.TestDefinition (log)
=== RUN   TestDefinition
=== PAUSE TestDefinition
=== CONT  TestDefinition
    integration_test.go:269: gopls definition a.go:7:2: exited with code -1, want success: true (gopls definition a.go:7:2: exit=-1 stdout=<<>> stderr=<<fork/exec /home/swarming/.swarming/w/ir/x/t/go-build1982600917/b729/cmd.test: bad address>>)
    integration_test.go:270: gopls definition a.go:7:2: stdout does not match [a.go:3:6-7: defined here as func f]; got <<>>
    integration_test.go:276: gopls definition a.go:4:7: stdout does not match [print.go.* defined here as func fmt.Println]; got <<>>
    integration_test.go:277: gopls definition a.go:4:7: stdout does not match [Println formats using the default formats for its operands]; got <<>>
--- FAIL: TestDefinition (11.56s)

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 8, 2025
@gopherbot gopherbot added this to the Unreleased milestone Feb 8, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestDefinition"
2025-02-06 18:01 x_tools-go1.23-netbsd-arm tools@bf4db91c release-branch.go1.23@a991f9c3 x/tools/gopls/internal/cmd.TestDefinition (log)
=== RUN   TestDefinition
=== PAUSE TestDefinition
=== CONT  TestDefinition
    integration_test.go:269: gopls definition a.go:7:2: exited with code -1, want success: true (gopls definition a.go:7:2: exit=-1 stdout=<<>> stderr=<<>>)
    integration_test.go:270: gopls definition a.go:7:2: stdout does not match [a.go:3:6-7: defined here as func f]; got <<>>
    integration_test.go:275: gopls definition a.go:4:7: exited with code -1, want success: true (gopls definition a.go:4:7: exit=-1 stdout=<<>> stderr=<<>>)
    integration_test.go:276: gopls definition a.go:4:7: stdout does not match [print.go.* defined here as func fmt.Println]; got <<>>
    integration_test.go:277: gopls definition a.go:4:7: stdout does not match [Println formats using the default formats for its operands]; got <<>>
--- FAIL: TestDefinition (288.76s)

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Archived in project
Development

No branches or pull requests

2 participants