Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: audit uintptr arguments in windows #7171

Closed
bradfitz opened this issue Jan 22, 2014 · 3 comments
Closed

syscall: audit uintptr arguments in windows #7171

bradfitz opened this issue Jan 22, 2014 · 3 comments
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jan 22, 2014

I notice lots of uintptr stuff in the syscall/*windows* files:

syscall_windows.go://sys        bind(s Handle, name uintptr, namelen int32) (err error)
[failretval==socket_error] = ws2_32.bind
syscall_windows.go://sys        connect(s Handle, name uintptr, namelen int32) (err
error) [failretval==socket_error] = ws2_32.connect

syscall_windows.go:func (sa *SockaddrInet4) sockaddr() (uintptr, int32, error) {
syscall_windows.go:     return uintptr(unsafe.Pointer(&sa.raw)),
int32(unsafe.Sizeof(sa.raw)), nil
syscall_windows.go:func (sa *SockaddrInet6) sockaddr() (uintptr, int32, error) {
syscall_windows.go:     return uintptr(unsafe.Pointer(&sa.raw)),
int32(unsafe.Sizeof(sa.raw)), nil
syscall_windows.go:func (sa *SockaddrUnix) sockaddr() (uintptr, int32, error) {
syscall_windows.go:     addr uintptr
syscall_windows.go:func connectEx(s Handle, name uintptr, namelen int32, sendBuf *byte,
sendDataLen uint32, bytesSent *uint32, overlapped *Overlapped) (err error) {

zsyscall_windows_386.go:func GetProcAddress(module Handle, procname string) (proc
uintptr, err error) {

Should be audited.
@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Jan 22, 2014

Comment 1:

I will be away for a week. I will investigate as soon as I can.
Alex
@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Apr 4, 2014

Comment 3:

https://golang.org/cl/84330043/

Status changed to Started.

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Apr 6, 2014

Comment 4:

This issue was closed by revision 258ee61.

Status changed to Fixed.

@bradfitz bradfitz added fixed labels Apr 6, 2014
@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.