crypto/x509: Verify should error if non-CA certificate contains name constraints

[dulanshuangqiao]

Go version

go version go1.23.2 linux/amd64

Output of go env in your module/workspace:

GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/liu/.cache/go-build'
GOENV='/home/liu/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/liu/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/liu/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/snap/go/10730'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/snap/go/10730/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.23.2'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/home/liu/.config/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build578094757=/tmp/go-build -gno-record-gcc-switches'

What did you do?

Perform certificate verification
go run go_verify.go

certs&program.zip

What did you see happen?

The execution result is passed verification
Certificate is valid!

What did you expect to see?

According to RFC 5280, Section 4.2.1.10, the Name Constraints extension is permitted only in CA certificates, not in end-entity certificates.
Cryptography fails to verify the certificate and throws the relevant error according to RFC5280: Certificate verification failed: validation failed: invalid extension: 2.5.29.30: Certificate contains prohibited extension

[gabyhelp]

Related Issues

• crypto/x509: NameConstraintsWithoutSANs when checking signing certificate #24151 (closed)
• crypto/x509: Certificate.Verify does not enforce name constraints correctly #59171 (closed)
• crypto/x509: Certificate Name Constraints starting with "." not validated properly #16347 (closed)
• crypto/x509: invalid certificate policies #65990 (closed)
• crypto/x509: Parser support for extensions #71499 (closed)
• crypto/x509: invalid implementation of Permitted DNS Names #14833 (closed)
• crypto/x509: support Inhibit Any-policy and Policy Constraints #68484 (closed)
• crypto/x509: Certificate.Verify does not consistently return UnknownAuthorityError #58777
• crypto/x509: Certificate parsing/verification supports non-compliant dNSName constraints #37535 (closed)

Related Code Changes

• crypto/x509: enforce all name constraints and support IP, email and URI constraints

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[mknyszek]

CC @golang/security