proposal: x/net/http2: add EnableConnectProtocol to Server

[WeidiDeng]

Proposal Details

In this accepted proposal a new field is added to http.HTTP2Config to allow the h2 server to declare Extended Connect support without explicitly importing x/net/http2 package.

However, currently h2 package uses a global debug env http2xconnect to control this setting.

Given that other fields in http.HTTP2Config have a corresponding field in http2.Server, and this config is merged with h2 configurations, I propose we remove http2xconnect debug environmental variable and add a new dedicated field EnableConnectProtocol to control whether extended connect is enabled.

By default this field is false, so websocket connection made by clients still uses h1 upgrade mechanism, thus backward compatible. Extended connect support has to be enabled explicitly by the user.

This proposal only adds a new API, so there is no breaking change.

[gabyhelp]

Related Issues

• proposal: x/net/http2: experiment with Extended CONNECT draft #27244 (closed)
• net/http: add support for SETTINGS_ENABLE_CONNECT_PROTOCOL #53208
• proposal: x/net/websocket: implement support for websockets over HTTP/2 #53209
• net/http: support unencrypted HTTP/2 (h2c) #67816 (closed)
• net/http: do not enable HTTP/2 extended connect by default #71128 (closed)
• proposal: x/net/http2/h2c: deprecate h2c package #72039

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[ianlancetaylor]

CC @neild

[janvavro]

Hello, I really appreciate adding extended connect support to x/net. Are there any timelines regarding implementing this proposal? We would like to avoid using debug env http2xconnect and rather enable the support in code.

Currently we pinned version of x/net to v0.33.0 where it was enabled by default. But it contains vulnerability GO-2025-3503 which we would like to get rid of eventually.

[seankhliao]

given that we plan to deprecate x/net/http2 in favor of the built in support in net/http,
what's preventing you from just using that?

[janvavro]

@seankhliao sorry I missed your reply. I’d love to use just net/http once the work is done. I don’t mind whether extended CONNECT support field lands in x/net or net/http — whichever comes first. If the standard library version: #53208 (already accepted) gets implemented first, I’m happy to drop x/net and switch to net/http.