Skip to content

x/tools/gopls/internal/cmd: go/types data race causes TestImplementations failures #72082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 3, 2025 · 55 comments
Closed

x/tools/gopls/internal/cmd: go/types data race causes TestImplementations failures #72082

gopherbot opened this issue Mar 3, 2025 · 55 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.19.0

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c006fcca6a by goroutine 4731:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x657
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x86
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (16.02s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 3, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-03 14:37 x_tools-gotip-freebsd-amd64-race tools@0efa5e51 go@0312e31e x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c006fcca6a by goroutine 4731:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x657
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x86
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (16.02s)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 3, 2025
@gopherbot gopherbot added this to the Unreleased milestone Mar 3, 2025
@adonovan
Copy link
Member

adonovan commented Mar 3, 2025

Dup of #71817 (types.CheckExpr mutates objects => data race)

@adonovan adonovan closed this as completed Mar 3, 2025
@gopherbot gopherbot reopened this Mar 3, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-03 20:04 x_tools-go1.23-linux-arm64-race tools@0ffdb82e release-branch.go1.23@e4772831 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00f47e52a by goroutine 6132:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1177258198/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1177258198/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (22.34s)

— watchflakes

@github-project-automation github-project-automation bot moved this from Done to Active in Test Flakes Mar 3, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-04 19:48 x_tools-gotip-linux-arm64-race tools@d81d6fcc go@0cfc6414 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c01597816a by goroutine 4748:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x4c8
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:78 +0x94
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:69 +0x40
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2229727998/gopls/internal/cache/analysis.go:906 +0xbc
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (12.07s)

— watchflakes

@adonovan adonovan changed the title x/tools/gopls/internal/cmd: TestImplementations failures x/tools/gopls/internal/cmd: go/types data race causes TestImplementations failures Mar 5, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-05 16:17 x_tools-go1.24-linux-arm64-race tools@07219402 release-branch.go1.24@e4119e9b x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00bdbe52a by goroutine 5022:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo4111022109/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo4111022109/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (16.57s)
2025-03-05 16:17 x_tools-gotip-linux-arm64-race tools@07219402 go@2c160414 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0137aa6a8 by goroutine 6005:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x520
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1360793670/gopls/internal/cache/analysis.go:605 +0x1dc
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1360793670/gopls/internal/cache/analysis.go:341 +0x430
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x70
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (17.85s)
2025-03-05 16:17 x_tools-gotip-linux-amd64-race tools@340f21a4 go@2c160414 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00e12596a by goroutine 5100:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x657
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2106427111/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2106427111/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x86
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (22.91s)
2025-03-05 16:48 x_tools-go1.24-windows-amd64-race tools@ece9e9ba release-branch.go1.24@e4119e9b x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<<C:\b\s\w\ir\x\w\goroot\src\fmt\print.go:64:2-8
        C:\b\s\w\ir\x\w\goroot\src\runtime\error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c017b94708 by goroutine 5970:
          go/types.(*Selection).Type()
              C:/b/s/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              C:/b/s/w/ir/x/w/targetrepo2870606075/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              C:/b/s/w/ir/x/w/targetrepo2870606075/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (19.13s)
2025-03-05 18:38 x_tools-go1.24-linux-amd64-longtest-race tools@db6008cb release-branch.go1.24@e4119e9b x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0130f3c08 by goroutine 5506:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3405952524/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3405952524/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (43.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-05 19:59 x_tools-go1.23-linux-amd64-race tools@25a90bef release-branch.go1.23@45aade7f x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c009bcf968 by goroutine 4771:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo831806434/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo831806434/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (25.96s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-05 20:18 x_tools-go1.24-linux-arm64-race tools@6a5b66be release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00ee220aa by goroutine 5532:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3984249478/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3984249478/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (19.37s)

— watchflakes

@ansaba ansaba modified the milestones: Unreleased, gopls/v0.19.0 Mar 6, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-07 21:08 x_tools-go1.24-darwin-amd64-race tools@29f81e9d release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00de5a8ea by goroutine 5633:
          go/types.(*Checker).ident()
              /Users/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3259244965/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3259244965/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (43.13s)
2025-03-07 21:08 x_tools-go1.24-linux-arm64-race tools@29f81e9d release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00dc6130a by goroutine 2476:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x97c
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:78 +0xac
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:69 +0x40
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3655494404/gopls/internal/cache/analysis.go:906 +0xd0
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (7.37s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-08 17:41 x_tools-go1.24-windows-amd64-race tools@8fa586e1 release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<<C:\b\s\w\ir\x\w\goroot\src\fmt\print.go:64:2-8
        C:\b\s\w\ir\x\w\goroot\src\runtime\error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0110f2a68 by goroutine 3955:
          go/types.(*Selection).Type()
              C:/b/s/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              C:/b/s/w/ir/x/w/targetrepo224832640/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              C:/b/s/w/ir/x/w/targetrepo224832640/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (23.84s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-08 17:41 x_tools-go1.24-linux-amd64-race tools@8fa586e1 release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c014dab78a by goroutine 3635:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0xc56
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:78 +0xe1
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:69 +0x44
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3865301713/gopls/internal/cache/analysis.go:906 +0x104
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (18.75s)
2025-03-10 11:26 x_tools-go1.24-linux-amd64-race tools@5a45ac2d release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0095c9368 by goroutine 4825:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1914189388/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1914189388/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (23.73s)

— watchflakes

@adonovan
Copy link
Member

Dup of #72122. Fixed by https://go.dev/cl/655437.

@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Mar 11, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-10 21:05 x_tools-go1.23-linux-amd64-race tools@cc7d6983 release-branch.go1.23@45aade7f x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00f326348 by goroutine 5703:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1006219545/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1006219545/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (27.82s)

— watchflakes

@gopherbot gopherbot reopened this Mar 12, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-11 21:41 x_tools-go1.23-darwin-amd64-race tools@381d68d8 release-branch.go1.23@45aade7f x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00d3a088a by goroutine 4627:
          go/types.(*Checker).ident()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3282045828/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3282045828/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (68.57s)
2025-03-11 21:41 x_tools-go1.24-linux-amd64-race tools@381d68d8 release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00b332caa by goroutine 4775:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0xc56
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:78 +0xe1
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:69 +0x44
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1647068026/gopls/internal/cache/analysis.go:906 +0x104
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (24.71s)

— watchflakes

@github-project-automation github-project-automation bot moved this from Done to Active in Test Flakes Mar 12, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-12 00:09 x_tools-go1.24-linux-arm64-race tools@bf702957 release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0132ddf08 by goroutine 2939:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x548
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo731528329/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo731528329/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (11.25s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-25 15:58 x_tools-go1.23-darwin-amd64-race tools@45b8eacd release-branch.go1.23@ec6e84df x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00aa1960a by goroutine 1652:
          go/types.(*Checker).ident()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/go/types/typexpr.go:122 +0xc56
...
          sync.(*Once).doSlow()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/sync/once.go:78 +0xe1
          sync.(*Once).Do()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/sync/once.go:69 +0x44
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo2574434445/gopls/internal/cache/analysis.go:906 +0x104
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (23.99s)
2025-03-25 17:31 x_tools-go1.23-linux-amd64-race tools@11a3153d release-branch.go1.23@ec6e84df x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c0104ad00a by goroutine 5519:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3037733973/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3037733973/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (25.92s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-25 18:43 x_tools-go1.23-darwin-amd64-race tools@7efe9a8b release-branch.go1.23@2c0a0fc6 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/fmt/print.go:64:2-8
        /Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c0118f8b2a by goroutine 4170:
          go/types.(*Checker).ident()
              /Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/go/types/typexpr.go:122 +0xc56
...
          sync.(*Once).doSlow()
              /Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/sync/once.go:78 +0xe1
          sync.(*Once).Do()
              /Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/sync/once.go:69 +0x44
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /Volumes/Work/s/w/ir/x/w/targetrepo3632775611/gopls/internal/cache/analysis.go:906 +0x104
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (36.44s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-25 18:43 x_tools-go1.23-darwin-amd64-race tools@7efe9a8b release-branch.go1.23@2c0a0fc6 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00a21ba88 by goroutine 4044:
          go/types.(*Selection).Type()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo198835423/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo198835423/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (38.18s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-25 18:43 x_tools-go1.23-linux-amd64-longtest-race tools@7efe9a8b release-branch.go1.23@c8551497 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c012cabc0a by goroutine 5842:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3510691485/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3510691485/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (38.25s)
2025-03-25 21:09 x_tools-go1.23-linux-amd64-longtest-race tools@b75dab25 release-branch.go1.23@2c0a0fc6 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c0108710ca by goroutine 5189:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/sync/once.go:78 +0xe1
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/sync/once.go:69 +0x44
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3908211357/gopls/internal/cache/analysis.go:906 +0x104
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (41.60s)
2025-03-25 21:09 x_tools-go1.23-linux-amd64-race tools@b75dab25 release-branch.go1.23@2c0a0fc6 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c009e0dbaa by goroutine 4588:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2345942161/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2345942161/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (25.81s)
2025-03-25 21:09 x_tools-go1.23-linux-arm64-race tools@b75dab25 release-branch.go1.23@2c0a0fc6 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c009ba90c8 by goroutine 4184:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/go/types/selection.go:101 +0x548
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo774324893/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo774324893/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (20.60s)
2025-03-25 21:39 x_tools-go1.23-linux-amd64-longtest-race tools@8be0d5f6 release-branch.go1.23@2c0a0fc6 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c010718caa by goroutine 5097:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/sync/once.go:78 +0xe1
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/sync/once.go:69 +0x44
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3136060844/gopls/internal/cache/analysis.go:906 +0x104
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (40.21s)
2025-03-25 21:39 x_tools-go1.23-linux-amd64-race tools@8be0d5f6 release-branch.go1.23@2c0a0fc6 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c010c4c288 by goroutine 5530:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1522207114/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1522207114/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (28.44s)
2025-03-25 21:39 x_tools-go1.23-linux-arm64-race tools@8be0d5f6 release-branch.go1.23@2c0a0fc6 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00db1fe4a by goroutine 4196:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/go/types/typexpr.go:122 +0x97c
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/sync/once.go:78 +0xac
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/sync/once.go:69 +0x40
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3109825237/gopls/internal/cache/analysis.go:906 +0xd0
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (22.07s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-26 02:20 x_tools-go1.23-windows-amd64-race tools@c1b6839e release-branch.go1.23@2c0a0fc6 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<<C:\b\s\w\ir\x\w\gopath\pkg\mod\golang.org\toolchain@v0.0.1-go1.24.0.windows-amd64\src\fmt\print.go:64:2-8
        C:\b\s\w\ir\x\w\gopath\pkg\mod\golang.org\toolchain@v0.0.1-go1.24.0.windows-amd64\src\runtime\error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c015709f6a by goroutine 5319:
          go/types.(*Checker).ident()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.windows-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              C:/b/s/w/ir/x/w/targetrepo3884948251/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              C:/b/s/w/ir/x/w/targetrepo3884948251/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (23.53s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-26 14:35 x_tools-go1.23-linux-amd64-longtest-race tools@6a913554 release-branch.go1.23@2c0a0fc6 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00bcf628a by goroutine 4848:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2548789381/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2548789381/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (40.40s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-26 14:12 x_tools-go1.23-linux-amd64-race tools@b3ce3e13 release-branch.go1.23@2c0a0fc6 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00f79a28a by goroutine 5167:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3916180754/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3916180754/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (25.72s)
2025-03-26 14:35 x_tools-go1.23-linux-amd64-race tools@6a913554 release-branch.go1.23@2c0a0fc6 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00da25c68 by goroutine 4948:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3473714156/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3473714156/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (25.32s)
2025-03-26 14:54 x_tools-go1.23-linux-amd64-race tools@2d8ef138 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c0163796ca by goroutine 5420:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/sync/once.go:78 +0xe1
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/sync/once.go:69 +0x44
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3055214194/gopls/internal/cache/analysis.go:906 +0x104
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (25.58s)
2025-03-26 18:38 x_tools-go1.23-linux-amd64-race tools@fbb70473 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c016a51b4a by goroutine 5325:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/sync/once.go:78 +0xe1
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/sync/once.go:69 +0x44
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3463888345/gopls/internal/cache/analysis.go:906 +0x104
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (24.61s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-26 14:35 x_tools-go1.23-darwin-amd64-race tools@6a913554 release-branch.go1.23@2c0a0fc6 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c014b7ee88 by goroutine 4682:
          go/types.(*Selection).Type()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo4223858241/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo4223858241/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (39.85s)
2025-03-26 14:54 x_tools-go1.23-darwin-amd64-race tools@2d8ef138 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/fmt/print.go:64:2-8
        /Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c010e43d2a by goroutine 5192:
          go/types.(*Checker).ident()
              /Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Volumes/Work/s/w/ir/x/w/targetrepo2535721959/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Volumes/Work/s/w/ir/x/w/targetrepo2535721959/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (41.65s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-26 18:38 x_tools-go1.23-linux-amd64-longtest-race tools@fbb70473 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00cf5bf6a by goroutine 4876:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo300344628/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo300344628/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (41.64s)
2025-03-26 18:38 x_tools-go1.23-windows-amd64-race tools@fbb70473 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<<C:\b\s\w\ir\x\w\gopath\pkg\mod\golang.org\toolchain@v0.0.1-go1.24.0.windows-amd64\src\fmt\print.go:64:2-8
        C:\b\s\w\ir\x\w\gopath\pkg\mod\golang.org\toolchain@v0.0.1-go1.24.0.windows-amd64\src\runtime\error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0151ca888 by goroutine 3990:
          go/types.(*Selection).Type()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.windows-amd64/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              C:/b/s/w/ir/x/w/targetrepo3993022974/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              C:/b/s/w/ir/x/w/targetrepo3993022974/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (24.71s)

— watchflakes

@adonovan
Copy link
Member

adonovan commented Mar 26, 2025 •
edited
Loading

Either the fix needs to get back-ported go1.23, which could be tricky depending on how much has changed, or we can simply disable this test on go1.23 and live with it in gopls in production until the next release. The race itself is benign, and it appears to be exercised only in this one test (for reasons I still don't understand: perhaps it is the only CLI test that (a) runs slow enough to allow analysis to make progress and (b) consumes or imports code that would trigger the rangeint analyzer?). So I favor that approach.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/661176 mentions this issue: gopls/internal/cmd: suppress TestImplementation on go1.23

@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Mar 26, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-26 20:05 x_tools-go1.23-windows-amd64-race tools@48421ae1 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<<C:\b\s\w\ir\x\w\gopath\pkg\mod\golang.org\toolchain@v0.0.1-go1.24.0.windows-amd64\src\fmt\print.go:64:2-8
        C:\b\s\w\ir\x\w\gopath\pkg\mod\golang.org\toolchain@v0.0.1-go1.24.0.windows-amd64\src\runtime\error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c01befc34a by goroutine 6059:
          go/types.(*Checker).ident()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.windows-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              C:/b/s/w/ir/x/w/targetrepo3301810749/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              C:/b/s/w/ir/x/w/targetrepo3301810749/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (22.78s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-26 22:04 x_tools-go1.23-linux-amd64-longtest-race tools@07cbcde0 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00f8e7c6a by goroutine 5260:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1820010416/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1820010416/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (40.53s)
2025-03-26 22:04 x_tools-go1.23-linux-arm64-race tools@07cbcde0 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00bc7b06a by goroutine 4956:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/go/types/typexpr.go:122 +0x97c
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/sync/once.go:78 +0xac
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/sync/once.go:69 +0x40
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo455323456/gopls/internal/cache/analysis.go:906 +0xd0
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (26.30s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-27 13:33 x_tools-go1.23-darwin-amd64-race tools@1b0b6881 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c011d58588 by goroutine 3515:
          go/types.(*Selection).Type()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3582731081/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3582731081/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (45.97s)

— watchflakes

@gopherbot gopherbot reopened this Mar 27, 2025
@github-project-automation github-project-automation bot moved this from Done to Active in Test Flakes Mar 27, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-28 15:15 x_tools-go1.23-linux-amd64-race tools@a857356d release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c012d6eeea by goroutine 5685:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo88505620/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo88505620/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (28.66s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-28 15:15 x_tools-go1.23-linux-amd64-longtest-race tools@a857356d release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c014efbcc8 by goroutine 5441:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3162398284/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3162398284/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (39.34s)
2025-03-28 20:22 x_tools-go1.23-linux-amd64-longtest-race tools@aac3cf02 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00d751c68 by goroutine 4634:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo9198851/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo9198851/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (38.52s)
2025-03-28 20:22 x_tools-go1.23-linux-arm64-race tools@aac3cf02 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c010c10b2a by goroutine 4410:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo4061364380/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo4061364380/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (14.17s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-28 20:22 x_tools-go1.23-darwin-amd64-race tools@aac3cf02 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00a9e8888 by goroutine 4487:
          go/types.(*Selection).Type()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo398199773/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo398199773/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (55.17s)

— watchflakes

@adonovan
Copy link
Member

adonovan commented Mar 31, 2025 •
edited by gabyhelp
Loading

D'oh, of course my fix (CL 661176) is not going to work because gopls always uses go1.24. The problem is that we haven't released the type checker fix yet; we need to wait for go1.24.2. In the meantime perhaps we can just disable this test with a note to reenable it.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-31 18:54 x_tools-go1.23-linux-amd64-race tools@5c9a69f9 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00e66ddea by goroutine 5367:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1621408746/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1621408746/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (24.35s)
2025-03-31 18:54 x_tools-go1.23-windows-amd64-race tools@5c9a69f9 release-branch.go1.23@c72a2bad x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<<C:\b\s\w\ir\x\w\gopath\pkg\mod\golang.org\toolchain@v0.0.1-go1.24.0.windows-amd64\src\fmt\print.go:64:2-8
        C:\b\s\w\ir\x\w\gopath\pkg\mod\golang.org\toolchain@v0.0.1-go1.24.0.windows-amd64\src\runtime\error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00c635a2a by goroutine 4882:
          go/types.(*Checker).ident()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.windows-amd64/src/go/types/typexpr.go:122 +0xc56
...
          sync.(*Once).doSlow()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.windows-amd64/src/sync/once.go:78 +0xe1
          sync.(*Once).Do()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.windows-amd64/src/sync/once.go:69 +0x44
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              C:/b/s/w/ir/x/w/targetrepo4149116390/gopls/internal/cache/analysis.go:906 +0x104
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (22.14s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-31 21:52 x_tools-go1.23-darwin-amd64-race tools@f3a6b96d release-branch.go1.23@7a2cfb70 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00a99e108 by goroutine 4630:
          go/types.(*Selection).Type()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3591741009/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3591741009/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (45.38s)
2025-03-31 21:52 x_tools-go1.23-linux-amd64-race tools@f3a6b96d release-branch.go1.23@7a2cfb70 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00dda08ea by goroutine 5114:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2767708702/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2767708702/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (25.69s)
2025-04-01 17:27 x_tools-go1.23-darwin-amd64-race tools@ead1fea4 release-branch.go1.23@7a2cfb70 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00c426e28 by goroutine 5437:
          go/types.(*Selection).Type()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.darwin-amd64/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3826573180/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3826573180/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (53.72s)
2025-04-01 17:57 x_tools-go1.23-windows-amd64-race tools@97789e84 release-branch.go1.23@7a2cfb70 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<<C:\b\s\w\ir\x\w\gopath\pkg\mod\golang.org\toolchain@v0.0.1-go1.24.0.windows-amd64\src\fmt\print.go:64:2-8
        C:\b\s\w\ir\x\w\gopath\pkg\mod\golang.org\toolchain@v0.0.1-go1.24.0.windows-amd64\src\runtime\error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c01acf0dca by goroutine 6034:
          go/types.(*Checker).ident()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.windows-amd64/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              C:/b/s/w/ir/x/w/targetrepo570328361/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              C:/b/s/w/ir/x/w/targetrepo570328361/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (19.68s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/662036 mentions this issue: gopls: require go1.24.2

@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Apr 1, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-04-01 19:34 x_tools-go1.23-linux-arm64-race tools@aee7ae56 release-branch.go1.23@7a2cfb70 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:536: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c008da942a by goroutine 3818:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2957704010/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2957704010/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.12.0/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (19.85s)

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
gopls/v0.19.0
Development

No branches or pull requests
4 participants
@ansaba @adonovan @gopherbot @findleyr