Skip to content

proposal: crypto/tls: disable SHA-1 signature algorithms in TLS 1.2 #72883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FiloSottile opened this issue Mar 15, 2025 · 2 comments
Open
Labels
LibraryProposal Issues describing a requested change to the Go standard library or x/ libraries, but not to a tool Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Milestone

Comments

@FiloSottile
Copy link
Contributor

FiloSottile commented Mar 15, 2025

In TLS 1.2, we still advertise and select (as the final preference) SHA-1 signature algorithms, rsa_pkcs1_sha1 and ecdsa_sha1. (In TLS 1.3 we reject them. In TLS 1.0 they are the only option.)

RFC 9155 made rejecting them a MUST, and we're overdue anyway.

I propose we implement RFC 9155 and remove support for SHA-1 signature algorithms in TLS 1.2.

The GODEBUG setting tlssha1=1 can be used to revert to the previous behavior.

/cc @golang/security

@FiloSottile FiloSottile added Proposal Proposal-Crypto Proposal related to crypto packages or other security issues labels Mar 15, 2025
@FiloSottile FiloSottile added this to the Go1.25 milestone Mar 15, 2025
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/658216 mentions this issue: crypto/tls: disable SHA-1 signature algorithms in TLS 1.2

@gabyhelp
Copy link

Related Issues

Related Code Changes

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gabyhelp gabyhelp added the LibraryProposal Issues describing a requested change to the Go standard library or x/ libraries, but not to a tool label Mar 15, 2025
@ianlancetaylor ianlancetaylor moved this to Incoming in Proposals Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LibraryProposal Issues describing a requested change to the Go standard library or x/ libraries, but not to a tool Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Projects
Status: Incoming
Development

No branches or pull requests

3 participants