Skip to content

x/tools/gopls/internal/cmd: TestDefinition failures #73224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gopherbot opened this issue Apr 8, 2025 · 1 comment
Closed

x/tools/gopls/internal/cmd: TestDefinition failures #73224

gopherbot opened this issue Apr 8, 2025 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestDefinition"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestDefinition
=== PAUSE TestDefinition
=== CONT  TestDefinition
    integration_test.go:286: gopls definition: stderr does not match [expects 1 argument]; got <<runtime: VirtualAlloc of 8192 bytes failed with errno=1455
        fatal error: out of memory
        
        runtime stack:
        runtime.throw({0x7ff6f1f0a2bc?, 0x4000390000?})
        	C:/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.2.windows-arm64/src/runtime/panic.go:1101 +0x38 fp=0xfdf95ffca0 sp=0xfdf95ffc70 pc=0x7ff6f12a7278
        runtime.sysUsedOS(0x4000390000, 0x2000)
...
        	runtime/proc.go:738
        runtime.schedinit()
        	runtime/proc.go:838 +0xf4 fp=0xdec33ff820 sp=0xdec33ff7c0 pc=0x7ff73e7a1aa4
        runtime.rt0_go()
        	runtime/asm_arm64.s:86 +0xac fp=0xdec33ff850 sp=0xdec33ff820 pc=0x7ff73e7d826c
        
        gopls: .\a.go:4:7: no package metadata for file file:///C:/Users/swarming/.swarming/w/ir/x/t/TestDefinition3680882125/001/a.go
        >>)
    integration_test.go:1247: invalid JSON unexpected end of JSON input
--- FAIL: TestDefinition (18.42s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 8, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestDefinition"
2025-04-07 19:33 x_tools-go1.23-windows-arm64 tools@9a1fbbdb release-branch.go1.23@7a2cfb70 x/tools/gopls/internal/cmd.TestDefinition (log)
=== RUN   TestDefinition
=== PAUSE TestDefinition
=== CONT  TestDefinition
    integration_test.go:286: gopls definition: stderr does not match [expects 1 argument]; got <<runtime: VirtualAlloc of 8192 bytes failed with errno=1455
        fatal error: out of memory
        
        runtime stack:
        runtime.throw({0x7ff6f1f0a2bc?, 0x4000390000?})
        	C:/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.2.windows-arm64/src/runtime/panic.go:1101 +0x38 fp=0xfdf95ffca0 sp=0xfdf95ffc70 pc=0x7ff6f12a7278
        runtime.sysUsedOS(0x4000390000, 0x2000)
...
        	runtime/proc.go:738
        runtime.schedinit()
        	runtime/proc.go:838 +0xf4 fp=0xdec33ff820 sp=0xdec33ff7c0 pc=0x7ff73e7a1aa4
        runtime.rt0_go()
        	runtime/asm_arm64.s:86 +0xac fp=0xdec33ff850 sp=0xdec33ff820 pc=0x7ff73e7d826c
        
        gopls: .\a.go:4:7: no package metadata for file file:///C:/Users/swarming/.swarming/w/ir/x/t/TestDefinition3680882125/001/a.go
        >>)
    integration_test.go:1247: invalid JSON unexpected end of JSON input
--- FAIL: TestDefinition (18.42s)

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 8, 2025
@gopherbot gopherbot added this to the Unreleased milestone Apr 8, 2025
@qmuntal qmuntal closed this as completed Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

2 participants