Skip to content

runtime: incorrect terminology 'reraised' in panic message #73526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rsc opened this issue Apr 28, 2025 · 3 comments
Closed

runtime: incorrect terminology 'reraised' in panic message #73526

rsc opened this issue Apr 28, 2025 · 3 comments
Assignees
@griesemer @mrkfrmn
Labels
BugReport Issues describing a possible bug in the Go implementation. compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.25

Comments

@rsc
Copy link
Contributor

rsc commented Apr 28, 2025

This terminology is not Go terminology:

--- FAIL: TestFib (0.00s)
panic: runStmt *ast.ForStmt [recovered, reraised]

...

“raised” is for exceptions, but Go does not have exceptions.
It should say “repanicked” or perhaps “re-panicked”.

There is actually one mention of "raised" in the spec, in an example, but that should probably be fixed as well.
"run-time panics raised by g" should be "run-time panics during g".

/cc @griesemer
@rsc rsc added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 28, 2025
@rsc rsc added this to the Go1.25 milestone Apr 28, 2025
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Apr 28, 2025
@gabyhelp gabyhelp added the BugReport Issues describing a possible bug in the Go implementation. label Apr 28, 2025
@KarthiDreamr
Copy link

Image
https://github.com/search?q=reraised+repo%3Agolang%2Fgo&type=code

  1. got 7 mentions of reraised, should I replace all of them with 're-panicked' ( includes function names too with 'RePanicked' ) ?
  2. Also should I pull reqest to main branch or to a specific branch ?

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/669975 mentions this issue: runtime: replace mentions of "raised" with "panicked"

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/670155 mentions this issue: doc: correct usage of "raise" in the spec

gopherbot pushed a commit that referenced this issue May 6, 2025
@gopherbot
spec: avoid use of "raise" in conjunction with panics
66ea0ee 
For #73526

Change-Id: I06d8ae9080695745db68a51635faa0b244c1760e
Reviewed-on: https://go-review.googlesource.com/c/go/+/670155
Reviewed-by: Robert Griesemer <gri@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Mark Freeman <mark@golang.org>
Auto-Submit: Mark Freeman <mark@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@griesemer griesemer

@mrkfrmn mrkfrmn

Labels
BugReport Issues describing a possible bug in the Go implementation. compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.25
Development

No branches or pull requests
6 participants
@rsc @griesemer @gopherbot @KarthiDreamr @gabyhelp @mrkfrmn