x/tools/gopls: completion: rank 'continue' higher inside a loop

[xieyuschen]

gopls version

v0.18.1

go env

irrevelant

What did you do?

func _() {
	for {
		if true {
			con| // | is the cursor position
		}
	}
}

What did you see happen?

The const is put as the best option.

What did you expect to see?

I expect to see the continue as the best option. My reason is:

• when we use if inside a for loop, we have more confidence typed con wants to use continue rather than const.
• const declared constants are prefered to put in file level.

Hence, I want to adjust the gopls logic for this part:

• check whether direct parent node is if-stmt
• check whether parent's ancestor has for stmt

If both of them are satisfied, provide continue with a higher score. I can help to do the code change.

Editor and settings

No response

Logs

No response

[xieyuschen]

Hi @adonovan @findleyr , how do you think about this change? I can help to do the code change.

[adonovan]

Seems reasonable.

[gopherbot]

Change https://go.dev/cl/673935 mentions this issue: gopls/internal/golang: completion: rank 'continue' under cond higher in loop

[gopherbot]

Change https://go.dev/cl/673915 mentions this issue: gopls/internal/golang: completion: rank 'continue' under cond higher in loop