Repository navigation
x/tools/gopls: completion: rank 'continue' higher inside a loop #73690
Description
gopls version
v0.18.1
go env
irrevelantWhat did you do?
func _() {
for {
if true {
con| // | is the cursor position
}
}
}
What did you see happen?
The const is put as the best option.
What did you expect to see?
I expect to see the continue as the best option. My reason is:
- when we use
ifinside a for loop, we have more confidence typedconwants to usecontinuerather thanconst. constdeclared constants are prefered to put in file level.
Hence, I want to adjust the gopls logic for this part:
- check whether direct parent node is if-stmt
- check whether parent's ancestor has for stmt
If both of them are satisfied, provide continue with a higher score. I can help to do the code change.
Editor and settings
No response
Logs
No response
Activity
[-]x/tools/gopls: issue title[/-][+]x/tools/gopls: provide continue with higher score when it's inside a if-stmt with a for loop[/+]xieyuschen commentedon May 13, 2025
Hi @adonovan @findleyr , how do you think about this change? I can help to do the code change.
[-]x/tools/gopls: provide continue with higher score when it's inside a if-stmt with a for loop[/-][+]x/tools/gopls: completion: rank 'continue' higher inside a loop[/+]adonovan commentedon May 13, 2025
Seems reasonable.
gopherbot commentedon May 18, 2025
Change https://go.dev/cl/673935 mentions this issue:
gopls/internal/golang: completion: rank 'continue' under cond higher in loopgopherbot commentedon May 18, 2025
Change https://go.dev/cl/673915 mentions this issue:
gopls/internal/golang: completion: rank 'continue' under cond higher in loop