x/tools/gopls: completion: rank 'struct' higher than imported symbols

[xieyuschen]

gopls version

v0.18.1

go env

irrelevant

What did you do?

Type struc inside a map declaration, and imports go/ast and go/types. You can use golang/tools package cmd/deadcode/deadcode.go to verify it.

What did you see happen?

I saw 3 symbols from the other packages are suggested above struct.

What did you expect to see?

I want the struct to be suggested with a higher score, so it could be put above the other 3 symbols from imported packages. The higher score should be given at least when a type usage is proper.

I can help to do the code change.

Editor and settings

No response

Logs

No response

[gabyhelp]

Related Issues

• x/tools/gopls: completion for struct literal inserts package name even if already in prefix #34872 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[adonovan]

The struct keyword rarely appears except on the right-hand side of a type declaration (or occasionally as the type of a var declaration). Why do we think it is a better completion than the identifiers?

[xieyuschen]

Why do we think it is a better completion than the identifiers?

I agree with you it's rare used, but if I want to type struct, I always need to type the full struct or press down button three times to get the struct completion.

• I don't have a way to easily accept the struct suggestion.
• I can type package name ssa/types/ast to get more suggestions for a certain pacakge(e.g, ast.StructType). I realised this may be a personal preference when writing code and might not be a strong guard, but this is the reason why I raised this issue.

[adonovan]

Rather than specialize the struct keyword, I would prefer a rule for prioritizing all keywords that herald type syntax (struct, func, interface, chan, map) in the few places where they are most often needed:

• in a type decl type T ‸
• in a var decl var ( x ‸
• recursively, in various parts of type grammar: map[‸]‸, chan ‸, *‸, []‸, func(‸, struct { x ‸, etc