x/tools/gopls: spurious SEGV in Promise

[adonovan]

#!stacks
"sigpanic" && "memoize.(*Promise).run.func2.1:+7"

Issue created by stacks.

Almost certainly more memory corruption.

This stack MTg0Ug was reported by telemetry:

• crash/crash
• runtime.gopanic:+69
• runtime.panicmem:=262
• runtime.sigpanic:+19
• golang.org/x/tools/internal/memoize.(*Promise).run.func2.1:+7
• runtime/trace.WithRegion:+19
• golang.org/x/tools/internal/memoize.(*Promise).run.func2:+1
• runtime.goexit:+0

golang.org/x/tools/gopls@v0.18.1 go1.24.3 linux/amd64 vscode (1)

Dups: pKRmmg dQbd7w CXbGog umrmMw s5ObEQ

[gabyhelp]

Related Issues

• x/tools/gopls: SEGV updating non-nil map in analysis.Validate #73437
• x/tools/gopls: SEGV while clearing memory in newobject #71561
• x/tools/gopls: nil deref in x/telemetry/internal/counter.(*Counter).add #73890
• gopls: automated issue report (crash) #63702 (closed)
• x/tools/gopls/test: flakes due to analyzer panics #56035 (closed)
• x/tools/gopls: automated issue report (crash) #44353 (closed)
• x/tools/gopls: SIGSEGV in cache.missingModuleError #42349 (closed)
• x/tools/gopls: SEGV accessing map[string]... #73387
• x/tools/gopls: SEGV in gcimporter.iexportCommon (bad SP) #72135
• x/tools/gopls: out-of-memory failure on Windows #71065

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[adonovan]

This stack pKRmmg was reported by telemetry:

• crash/crash
• runtime.gopanic:+69,+0x167
• runtime.panicmem:=262,+0x358
• runtime.sigpanic:+19,+0x328
• golang.org/x/tools/go/ast/inspector.walk:+12,+0x473
• golang.org/x/tools/go/ast/inspector.walk:+16,+0x2d8
• golang.org/x/tools/go/ast/inspector.walkList[...]:=21,+0x3154
• golang.org/x/tools/go/ast/inspector.walk:+30,+0x8fd
• golang.org/x/tools/go/ast/inspector.walk:+292,+0x67d
• golang.org/x/tools/go/ast/inspector.walkList[...]:=21,+0x19c4
• golang.org/x/tools/go/ast/inspector.walk:+305,+0x13f1
• golang.org/x/tools/go/ast/inspector.traverse:+18,+0x13e
• golang.org/x/tools/go/ast/inspector.New:=74,+0x4e6
• golang.org/x/tools/gopls/internal/cache/parsego.Parse:+75,+0x4ca
• golang.org/x/tools/gopls/internal/cache.(*parseCache).startParse.func1:+5,+0xf5
• golang.org/x/tools/gopls/internal/util/memoize.(*Promise).run.func2.1:+7,+0x95
• runtime/trace.WithRegion:+19,+0xd0
• golang.org/x/tools/gopls/internal/util/memoize.(*Promise).run.func2:+1,+0x11c
• runtime.goexit:+0,+0x0

golang.org/x/tools/gopls@v0.20.0 go1.25.3 linux/amd64 gopls.client=vscode (1)

Use this command to reproduce the executable:
(HOME=$(mktemp -d); GOOS=linux GOARCH=amd64 GOTOOLCHAIN=go1.25.3 go install golang.org/x/tools/gopls@v0.20.0 && find $HOME/go/bin -type f)
To disassemble: go tool objdump exe | less

[adonovan]

Found new stacks for predicate:

#!stacks
"sigpanic" && "memoize.(*Promise).run.func2.1:+7"

This stack dQbd7w was reported by telemetry:

• crash/crash
• runtime.gopanic:+69,+0x167
• runtime.panicmem:=262,+0x358
• runtime.sigpanic:+19,+0x328
• golang.org/x/tools/go/ast/inspector.walk:+55,+0x3309
• golang.org/x/tools/go/ast/inspector.walk:+85,+0x2caa
• golang.org/x/tools/go/ast/inspector.walkList[...]:=21,+0x23b2
• golang.org/x/tools/go/ast/inspector.walk:+159,+0x233e
• golang.org/x/tools/go/ast/inspector.walkList[...]:=21,+0x222c
• golang.org/x/tools/go/ast/inspector.walk:+176,+0xf09
• golang.org/x/tools/go/ast/inspector.walk:+227,+0x1afc
• golang.org/x/tools/go/ast/inspector.walkList[...]:=21,+0x222c
• golang.org/x/tools/go/ast/inspector.walk:+176,+0xf09
• golang.org/x/tools/go/ast/inspector.walk:+297,+0x706
• golang.org/x/tools/go/ast/inspector.walkList[...]:=21,+0x19c4
• golang.org/x/tools/go/ast/inspector.walk:+305,+0x13f1
• golang.org/x/tools/go/ast/inspector.traverse:+18,+0x13e
• golang.org/x/tools/go/ast/inspector.New:=74,+0x4e6
• golang.org/x/tools/gopls/internal/cache/parsego.Parse:+75,+0x4ca
• golang.org/x/tools/gopls/internal/cache.(*parseCache).startParse.func1:+5,+0xf5
• golang.org/x/tools/gopls/internal/util/memoize.(*Promise).run.func2.1:+7,+0x95
• runtime/trace.WithRegion:+19,+0xd0
• golang.org/x/tools/gopls/internal/util/memoize.(*Promise).run.func2:+1,+0x11c

golang.org/x/tools/gopls@v0.20.0 go1.25.4 linux/amd64 gopls.client=vscode (1)

Use this command to reproduce the executable:
(HOME=$(mktemp -d); GOOS=linux GOARCH=amd64 GOTOOLCHAIN=go1.25.4 go install golang.org/x/tools/gopls@v0.20.0 && find $HOME/go/bin -type f)
To disassemble: go tool objdump exe | less

[adonovan]

Found new stacks for predicate:

#!stacks
"sigpanic" && "memoize.(*Promise).run.func2.1:+7"

This stack CXbGog was reported by telemetry:

• crash/crash
• runtime.throw:+9,+0x33
• runtime.sigpanic:+33,+0x213
• fmt.(*pp).doPrintf:+9,+0xc84
• fmt.Sprintf:+2,+0x4b
• golang.org/x/tools/internal/gocommand.cmdDebugStr:+19,+0x53f
• golang.org/x/tools/internal/gocommand.(*Invocation).run:+69,+0xa53
• golang.org/x/tools/internal/gocommand.(*Invocation).runWithFriendlyError:+1,+0x37
• golang.org/x/tools/internal/gocommand.(*Runner).runConcurrent:+10,+0xef
• golang.org/x/tools/internal/gocommand.(*Runner).RunRaw:+7,+0x1d7
• golang.org/x/tools/internal/gocommand.(*Runner).Run:+4,+0x1bb
• golang.org/x/tools/gopls/internal/cache.modTidyImpl:+16,+0x2c7
• golang.org/x/tools/gopls/internal/cache.(*Snapshot).ModTidy.func1:+1,+0x47
• golang.org/x/tools/gopls/internal/util/memoize.(*Promise).run.func2.1:+7,+0x83
• runtime/trace.WithRegion:+19,+0xbf
• golang.org/x/tools/gopls/internal/util/memoize.(*Promise).run.func2:+1,+0xcf
• runtime.goexit:+0,+0x3

golang.org/x/tools/gopls@v0.21.1 go1.25.6 darwin/arm64 gopls.client=vscode-insiders (1)

Use this command to reproduce the executable:
(HOME=$(mktemp -d); GOOS=darwin GOARCH=arm64 GOTOOLCHAIN=go1.25.6 go install golang.org/x/tools/gopls@v0.21.1 && find $HOME/go/bin -type f)
To disassemble: go tool objdump exe | less