Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: data race in FailNow #7401

Closed
dvyukov opened this issue Feb 24, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@dvyukov
Copy link
Member

commented Feb 24, 2014

go version devel +3cf533be5e36 Mon Feb 24 16:34:51 2014 +0900 linux/amd64

$ go test -race testing

WARNING: DATA RACE
Write by goroutine 71:
  testing.(*common).FailNow()
      src/pkg/testing/testing.go:303 +0x48
  testing.(*common).Fatal()
      src/pkg/testing/testing.go:339 +0x78
  testing_test.func·003()
      src/pkg/testing/benchmark_test.go:91 +0x312
  testing.func·002()
      src/pkg/testing/benchmark.go:416 +0x17d

Previous write by goroutine 70:
  testing.(*common).FailNow()
      src/pkg/testing/testing.go:303 +0x48
  testing.(*common).Fatal()
      src/pkg/testing/testing.go:339 +0x78
  testing_test.func·003()
      src/pkg/testing/benchmark_test.go:91 +0x312
  testing.func·002()
      src/pkg/testing/benchmark.go:416 +0x17d

Goroutine 71 (running) created at:
  testing.(*B).RunParallel()
      src/pkg/testing/benchmark.go:417 +0x3a1
  testing_test.func·004()
      src/pkg/testing/benchmark_test.go:92 +0xc4
  testing.(*B).runN()
      src/pkg/testing/benchmark.go:124 +0xe8
  testing.(*B).launch()
      src/pkg/testing/benchmark.go:197 +0xc6

Goroutine 70 (finished) created at:
  testing.(*B).RunParallel()
      src/pkg/testing/benchmark.go:417 +0x3a1
  testing_test.func·004()
      src/pkg/testing/benchmark_test.go:92 +0xc4
  testing.(*B).runN()
      src/pkg/testing/benchmark.go:124 +0xe8
  testing.(*B).launch()
      src/pkg/testing/benchmark.go:197 +0xc6
@dvyukov

This comment has been minimized.

Copy link
Member Author

commented Feb 24, 2014

Comment 1:

This issue was closed by revision cd13a57.

Status changed to Fixed.

@dvyukov dvyukov added fixed labels Feb 24, 2014

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015

@rsc rsc removed the release-go1.3 label Apr 14, 2015

@golang golang locked and limited conversation to collaborators Jun 25, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.