Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/rpc/jsonrpc: drop response on error #7442

Closed
gopherbot opened this issue Mar 3, 2014 · 6 comments
Closed

net/rpc/jsonrpc: drop response on error #7442

gopherbot opened this issue Mar 3, 2014 · 6 comments
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 3, 2014

by yac.cz0:

net/rpc/jsonrpc/server.go: response result contains empty object "{}" instead
of "null" when error occurs

see `hg export`-ed patch in attachment

Attachments:

  1. jsonrpc-result.patch (1482 bytes)
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 3, 2014

Comment 1 by yac.cz0:

I'm sorry this is my first time with hg so I guess I accidentaly two commits into the
patch instead of only the one fixing server.go
@rsc
Copy link
Contributor

@rsc rsc commented Mar 3, 2014

Comment 2:

Please submit the patch as described at golang.org/doc/contribute.html. Thanks. (The
1-line diff itself looks fine.)

Labels changed: added release-go1.3.

Status changed to Accepted.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 5, 2014

Comment 3 by yac.cz0:

https://golang.org/cl/71230045/
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Mar 6, 2014

Comment 4:

This issue was updated by revision 31731b2.

LGTM=adg
R=adg
CC=golang-codereviews
https://golang.org/cl/69860056
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Mar 8, 2014

Comment 5:

This issue was closed by revision 7718c62.

Status changed to Fixed.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 9, 2014

Comment 6:

CL https://golang.org/cl/71230045 references this issue.
@gopherbot gopherbot added fixed labels Apr 9, 2014
@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.