net: unrecognized failures

[gopherbot]

#!watchflakes
default <- pkg == "net" && test == ""

Issue created automatically to collect these failures.

Example (log):

PASS
==================
WARNING: DATA RACE
Write at 0x0001406da008 by main goroutine:
  net.uninstallTestHooks()
      C:/b/s/w/ir/x/w/goroot/src/net/main_windows_test.go:34 +0x9c
  sync.(*Once).doSlow()
      C:/b/s/w/ir/x/w/goroot/src/sync/once.go:78 +0xd1
  sync.(*Once).Do()
      C:/b/s/w/ir/x/w/goroot/src/sync/once.go:69 +0x44
...
(inet4, datagram, default): opened=90 connected=37 listened=0 accepted=0 closed=90 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=0 closefailed=0
(inet6, datagram, default): opened=27 connected=2 listened=0 accepted=0 closed=27 openfailed=0 connectfailed=4 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, raw, 1): opened=1 connected=0 listened=0 accepted=0 closed=1 openfailed=0 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(local, datagram, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=3 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(local, seqpacket, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=4 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, stream, default): opened=726 connected=0 listened=107 accepted=0 closed=724 openfailed=0 connectfailed=361 listenfailed=0 acceptfailed=247 closefailed=0
(local, stream, default): opened=56 connected=16 listened=26 accepted=0 closed=56 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=7 closefailed=0

Found 1 data race(s)
FAIL	net	30.289s

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == ""

2025-07-23 18:41 gotip-windows-amd64-race go@2696a11a net (log)

PASS
==================
WARNING: DATA RACE
Write at 0x0001406da008 by main goroutine:
  net.uninstallTestHooks()
      C:/b/s/w/ir/x/w/goroot/src/net/main_windows_test.go:34 +0x9c
  sync.(*Once).doSlow()
      C:/b/s/w/ir/x/w/goroot/src/sync/once.go:78 +0xd1
  sync.(*Once).Do()
      C:/b/s/w/ir/x/w/goroot/src/sync/once.go:69 +0x44
...
(inet4, datagram, default): opened=90 connected=37 listened=0 accepted=0 closed=90 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=0 closefailed=0
(inet6, datagram, default): opened=27 connected=2 listened=0 accepted=0 closed=27 openfailed=0 connectfailed=4 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, raw, 1): opened=1 connected=0 listened=0 accepted=0 closed=1 openfailed=0 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(local, datagram, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=3 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(local, seqpacket, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=4 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, stream, default): opened=726 connected=0 listened=107 accepted=0 closed=724 openfailed=0 connectfailed=361 listenfailed=0 acceptfailed=247 closefailed=0
(local, stream, default): opened=56 connected=16 listened=26 accepted=0 closed=56 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=7 closefailed=0

Found 1 data race(s)
FAIL	net	30.289s

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == ""

2025-08-05 17:41 gotip-windows-amd64-race go@c0025d5e net (log)

PASS
==================
WARNING: DATA RACE
Write at 0x0001406d2010 by main goroutine:
  net.uninstallTestHooks()
      C:/b/s/w/ir/x/w/goroot/src/net/main_windows_test.go:34 +0x9c
  sync.(*Once).doSlow()
      C:/b/s/w/ir/x/w/goroot/src/sync/once.go:78 +0xd1
  sync.(*Once).Do()
      C:/b/s/w/ir/x/w/goroot/src/sync/once.go:69 +0x44
...
(inet4, raw, 1): opened=1 connected=0 listened=0 accepted=0 closed=1 openfailed=0 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(local, datagram, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=3 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(local, seqpacket, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=4 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, stream, default): opened=730 connected=0 listened=107 accepted=0 closed=728 openfailed=0 connectfailed=362 listenfailed=0 acceptfailed=250 closefailed=0
(local, stream, default): opened=56 connected=16 listened=26 accepted=0 closed=56 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=8 closefailed=0
(inet6, stream, default): opened=62 connected=0 listened=18 accepted=0 closed=62 openfailed=0 connectfailed=24 listenfailed=0 acceptfailed=16 closefailed=0
(inet4, datagram, default): opened=90 connected=37 listened=0 accepted=0 closed=90 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=0 closefailed=0

Found 1 data race(s)
FAIL	net	15.630s

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == ""

2025-08-12 16:00 gotip-windows-amd64-race go@d0a64f79 net (log)

PASS
==================
WARNING: DATA RACE
Write at 0x0001406da010 by main goroutine:
  net.uninstallTestHooks()
      C:/b/s/w/ir/x/w/goroot/src/net/main_windows_test.go:34 +0x9c
  sync.(*Once).doSlow()
      C:/b/s/w/ir/x/w/goroot/src/sync/once.go:78 +0xd1
  sync.(*Once).Do()
      C:/b/s/w/ir/x/w/goroot/src/sync/once.go:69 +0x44
...
(local, seqpacket, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=4 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, stream, default): opened=730 connected=0 listened=109 accepted=0 closed=730 openfailed=0 connectfailed=363 listenfailed=0 acceptfailed=245 closefailed=0
(local, stream, default): opened=58 connected=17 listened=27 accepted=0 closed=58 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=8 closefailed=0
(inet6, stream, default): opened=68 connected=0 listened=19 accepted=0 closed=68 openfailed=0 connectfailed=25 listenfailed=0 acceptfailed=20 closefailed=0
(inet4, datagram, default): opened=95 connected=39 listened=0 accepted=0 closed=95 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=0 closefailed=0
(inet6, datagram, default): opened=29 connected=3 listened=0 accepted=0 closed=29 openfailed=0 connectfailed=4 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, raw, 1): opened=1 connected=0 listened=0 accepted=0 closed=1 openfailed=0 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0

Found 1 data race(s)
FAIL	net	30.752s

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == ""

2025-09-12 17:20 gotip-windows-amd64-race go@911455fe net (log)

PASS
==================
WARNING: DATA RACE
Write at 0x0001406e4010 by main goroutine:
  net.uninstallTestHooks()
      C:/b/s/w/ir/x/w/goroot/src/net/main_windows_test.go:34 +0x9c
  sync.(*Once).doSlow()
      C:/b/s/w/ir/x/w/goroot/src/sync/once.go:78 +0xd1
  sync.(*Once).Do()
      C:/b/s/w/ir/x/w/goroot/src/sync/once.go:69 +0x44
...
(inet6, datagram, default): opened=29 connected=3 listened=0 accepted=0 closed=29 openfailed=0 connectfailed=4 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, raw, 1): opened=1 connected=0 listened=0 accepted=0 closed=1 openfailed=0 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(local, datagram, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=3 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(local, seqpacket, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=4 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, stream, default): opened=722 connected=0 listened=109 accepted=0 closed=721 openfailed=0 connectfailed=361 listenfailed=0 acceptfailed=240 closefailed=0
(local, stream, default): opened=57 connected=17 listened=27 accepted=0 closed=57 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=7 closefailed=0
(inet6, stream, default): opened=67 connected=0 listened=19 accepted=0 closed=67 openfailed=0 connectfailed=25 listenfailed=0 acceptfailed=19 closefailed=0

Found 1 data race(s)
FAIL	net	55.094s

— watchflakes

[linsite]

It seems that uninstallTestHooks has race with internal/poll.FD.destroy.

Shouldn't forceCloseSockets be called before uninstallTestHooks in net/main_test.go? i.e. sockets which are created by installed hooks should be closed by them, too.

testHookUninstaller.Do(uninstallTestHooks)
if testing.Verbose() {
printRunningGoroutines()
printInflightSockets()
printSocketStats()
}
forceCloseSockets()

cc @ianlancetaylor

[ianlancetaylor]

It looks like some test has failed to close a socket. The error is happening when the finalizer is run to close the socket. We may need to find out which test is failing to close which socket.

I don't see why forceCloseSockets will help, because the socket is not being printed by printInflightSockets. But maybe I'm missing something.

[linsite]

It looks like some test has failed to close a socket. The error is happening when the finalizer is run to close the socket. We may need to find out which test is failing to close which socket.

Thanks, Ian. You're right. Some tests did fail with mismatched opened/closed TCP4 sockets, but others didn't. I'll look into that.

Here is a mismatched one:

(inet4, stream, default): opened=722 connected=0 listened=109 accepted=0 closed=721 openfailed=0 connectfailed=361 listenfailed=0 acceptfailed=240 closefailed=0

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == ""

2025-09-16 17:04 go1.25-windows-amd64-race release-branch.go1.25@be611321 net (log)

PASS
==================
WARNING: DATA RACE
Read at 0x0001406da008 by goroutine 7:
  internal/poll.(*FD).destroy()
      C:/b/s/w/ir/x/w/goroot/src/internal/poll/fd_windows.go:461 +0x15e
  internal/poll.(*FD).decref()
      C:/b/s/w/ir/x/w/goroot/src/internal/poll/fd_mutex.go:213 +0x36
  internal/poll.(*FD).Close()
      C:/b/s/w/ir/x/w/goroot/src/internal/poll/fd_windows.go:482 +0xc4
...
(local, stream, default): opened=56 connected=16 listened=26 accepted=0 closed=56 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=8 closefailed=0
(inet6, stream, default): opened=66 connected=0 listened=18 accepted=0 closed=66 openfailed=0 connectfailed=24 listenfailed=0 acceptfailed=20 closefailed=0
(inet4, datagram, default): opened=91 connected=37 listened=0 accepted=0 closed=90 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=0 closefailed=0
(inet6, datagram, default): opened=27 connected=2 listened=0 accepted=0 closed=27 openfailed=0 connectfailed=4 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, raw, 1): opened=1 connected=0 listened=0 accepted=0 closed=1 openfailed=0 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(local, datagram, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=3 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(local, seqpacket, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=4 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0

Found 1 data race(s)
FAIL	net	29.702s

— watchflakes

[linsite]

I failed to reproduce this locally. I wonder if it's worthy to reproduce or just work around it like https://go-review.googlesource.com/c/go/+/704455.

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == ""

2026-04-01 10:10 gotip-windows-amd64-race go@a409055b net (log)

PASS
==================
WARNING: DATA RACE
Write at 0x0001406f0620 by main goroutine:
  net.uninstallTestHooks()
      C:/b/s/w/ir/x/w/goroot/src/net/main_windows_test.go:34 +0x9c
  sync.(*Once).doSlow()
      C:/b/s/w/ir/x/w/goroot/src/sync/once.go:78 +0xa1
  main.main()
      _testmain.go:612 +0x171
...
(inet6, datagram, default): opened=29 connected=3 listened=0 accepted=0 closed=29 openfailed=0 connectfailed=4 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, raw, 1): opened=1 connected=0 listened=0 accepted=0 closed=1 openfailed=0 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(local, datagram, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=3 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(local, seqpacket, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=4 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, stream, default): opened=728 connected=0 listened=109 accepted=0 closed=727 openfailed=0 connectfailed=361 listenfailed=0 acceptfailed=247 closefailed=0
(local, stream, default): opened=58 connected=17 listened=27 accepted=0 closed=58 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=8 closefailed=0
(inet6, stream, default): opened=69 connected=0 listened=20 accepted=0 closed=69 openfailed=0 connectfailed=25 listenfailed=0 acceptfailed=20 closefailed=0

Found 1 data race(s)
FAIL	net	67.210s

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == ""

2026-04-07 19:14 go1.26-windows-amd64-race release-branch.go1.26@3a4577a2 net (log)

PASS
==================
WARNING: DATA RACE
Write at 0x0001406fb4a0 by main goroutine:
  net.uninstallTestHooks()
      C:/b/s/w/ir/x/w/goroot/src/net/main_windows_test.go:34 +0x9c
  sync.(*Once).doSlow()
      C:/b/s/w/ir/x/w/goroot/src/sync/once.go:78 +0xa1
  main.main()
      _testmain.go:608 +0x171
...
(local, seqpacket, default): opened=0 connected=0 listened=0 accepted=0 closed=0 openfailed=4 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, stream, default): opened=731 connected=0 listened=109 accepted=0 closed=727 openfailed=0 connectfailed=362 listenfailed=0 acceptfailed=249 closefailed=0
(local, stream, default): opened=58 connected=17 listened=27 accepted=0 closed=58 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=8 closefailed=0
(inet6, stream, default): opened=68 connected=0 listened=19 accepted=0 closed=68 openfailed=0 connectfailed=25 listenfailed=0 acceptfailed=20 closefailed=0
(inet4, datagram, default): opened=95 connected=39 listened=0 accepted=0 closed=95 openfailed=0 connectfailed=1 listenfailed=0 acceptfailed=0 closefailed=0
(inet6, datagram, default): opened=29 connected=3 listened=0 accepted=0 closed=29 openfailed=0 connectfailed=4 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, raw, 1): opened=1 connected=0 listened=0 accepted=0 closed=1 openfailed=0 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0

Found 1 data race(s)
FAIL	net	33.419s

— watchflakes