cmd/dist: failed to bootstrap on Mac OS X 10.6

[gopherbot]

by odysseus9672:

What does 'go version' print?
The last version I successfully built:
go version devel +1a0714819799 Thu Mar 06 00:09:09 2014 +1100 darwin/amd64

What steps reproduce the problem?
If possible, include a link to a program on play.golang.org.

cd /usr/local/go/src
hg pull
hg update default
./all.bash

What happened?
# Building compilers and Go bootstrap tool for host, darwin/amd64.
lib9
cc1: warnings being treated as errors
cc1: warning: -Wuninitialized is not supported without -O
cc1: warnings being treated as errors
cc1: warning: -Wuninitialized is not supported without -O
cc1: warnings being treated as errors
cc1: warning: -Wuninitialized is not supported without -O
go tool dist: FAILED: cc -I/usr/local/scisoft/include/ -Wall -Wstrict-prototypes -Wextra
-Wunused -Wuninitialized -Wno-sign-compare -Wno-missing-braces -Wno-parentheses
-Wno-unknown-pragmas -Wno-switch -Wno-comment -Wno-missing-field-initializers -Werror
-fno-common -ggdb -pipe -fmessage-length=0 -mmacosx-version-min=10.6 -c -m64 -I
/usr/local/go/include -DPLAN9PORT -I /usr/local/go/src/lib9 -o
/usr/local/go/pkg/obj/lib9/atoi.o /usr/local/go/src/lib9/atoi.c

What should have happened instead?
The Go distribution should have built.

Please provide any additional information below.
xcodebuild -version
Xcode 3.2.6
Component versions: DevToolsCore-1809.0; DevToolsSupport-1806.0
BuildVersion: 10M2518

[minux]

Comment 1:

what if you delete the -Wuninitialized in cmd/dist/build.c and try running all.bash
again?

Labels changed: added release-go1.3maybe, repo-main.

Status changed to WaitingForReply.

[gopherbot]

Comment 2 by odysseus9672:

If I delete that, the build proceeds without error.
Now:
go version
go version devel +3766534aabb9 Fri Mar 07 11:27:01 2014 -0500 darwin/amd64

[minux]

Comment 3:

did you have $CFLAGS environment variable set?
because otherwise we should provide -O2 to gcc.

[gopherbot]

Comment 4 by odysseus9672:

Yes, I have a package installed called Scisoft ( http://scisoftosx.dyndns.org/ ) that
sets CFLAGS and CCFLAGS:
echo $CCFLAGS
-I/usr/local/scisoft/include/
echo $CFLAGS
-I/usr/local/scisoft/include/
Is there a reason why having these set blocks the addition of -O2? Is the assumption
that the user can control the build process by setting their own -O flag?

[minux]

Comment 5:

yeah, a recent change makes -O2 optional, and if you've set
$CFLAGS, it will be used instead of -O2 (it is assumed that
you set CFLAGS to override the optimization setting).
could you please revert changes to cmd/dist and try this CL?
https://golang.org/cl/72360045
I think it will solve your problem. Thank you.

Owner changed to @minux.

Status changed to Started.

[gopherbot]

Comment 6 by odysseus9672:

Yep, it solves the problem.

[minux]

Comment 7:

This issue was closed by revision 4271dd4.

Status changed to Fixed.