Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: certs fail on current Windows due to 3/11/2014 root update #7523

Closed
rsc opened this issue Mar 12, 2014 · 1 comment
Closed

crypto/x509: certs fail on current Windows due to 3/11/2014 root update #7523

rsc opened this issue Mar 12, 2014 · 1 comment
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Mar 12, 2014

The root update on 3/11/2014 removed the Verisign root cert that the Go tests use. This
only affects the 'TestSystemVerify' test in crypto/x509. I fixed the windows-amd64
builder by manually adding the certificate back to Windows using the instructions at
[1], except that I had to explicitly change the cert from 'Code Signing' to 'Verifying
Servers'.

agl says that the tests need to be updated, but it's a little non-trivial. For now the
crypto/x509 test will fail except on the builder. If that's a problem we can disable the
test, but I'd like to keep it if we can.

[1] http://www.sqlservermart.com/HowTo/Windows_Import_Certificate.aspx
@agl
Copy link
Contributor

@agl agl commented Mar 27, 2014

Comment 1:

This issue was closed by revision 0f272d1.

Status changed to Fixed.

@rsc rsc added fixed labels Mar 27, 2014
@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.