-
Notifications
You must be signed in to change notification settings - Fork 18.8k
Closed
Labels
AutomationIssues created by gopherbot or watchflakes automation.Issues created by gopherbot or watchflakes automation.ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.
Milestone
Description
CL 702376 introduced a new test TestMCPVulncheckCommand which always fails on Plan 9, for example here:
--- FAIL: TestMCPVulncheckCommand (13.41s)
mcp_test.go:340: calling "initialize": EOF
FAIL
FAIL golang.org/x/tools/gopls/internal/cmd 491.900s
The error message "EOF" does not have a huge amount of diagnostic value, but the initialisation in this test follows the pattern of the other failing tests in mcp_test.go reported in issue #74580, and therefore I believe the test should be skipped on platforms where fsnotify is not supported.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
AutomationIssues created by gopherbot or watchflakes automation.Issues created by gopherbot or watchflakes automation.ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.