x/tools/gopls: analysis key is ignored in neovim/lspconfig

[OneOfOne]

Go version

go version go1.25.1 linux/amd64
golang.org/x/tools/gopls v0.20.0

Output of go env in your module/workspace:

AR='ar'
CC='gcc'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='g++'
GCCGO='gccgo'
GO111MODULE=''
GOAMD64='v4'
GOARCH='amd64'
GOAUTH='netrc'
GOBIN='/home/oneofone/code/go/bin'
GOCACHE='/home/oneofone/.cache/go-build'
GOCACHEPROG=''
GODEBUG=''
GOENV='/home/oneofone/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1869883985=/tmp/go-build -gno-record-gcc-switches'
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMOD='/dev/null'
GOMODCACHE='/home/oneofone/code/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/oneofone/code/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/lib/go'
GOSUMDB='sum.golang.org'
GOTELEMETRY='local'
GOTELEMETRYDIR='/home/oneofone/.config/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/lib/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.25.1'
GOWORK=''
PKG_CONFIG='pkg-config'

What did you do?

Added golsp to lspconfig settings with this:

	{
		'neovim/nvim-lspconfig',
		opts = {
			servers = {
				gopls = {
					settings = {
						gopls = {
							completeFunctionCalls = false,
							usePlaceholders = false,
							analyses = {
								fieldalignment = true,
								fillreturns = false,
							},
						},
					},
				},
			},
		},
	},

What did you see happen?

Analysis settings are completely ignored.

What did you expect to see?

Analyses settings to be honored.

[gabyhelp]

Related Issues

• x/tools/gopls: bad go.mod affects anayses but not formatting; no errors in logs #44204 (closed)
• x/tools/gopls: analyzer fillstruct does not return any diagnoses #63667 (closed)
• x/tools/gopls: unusedparams analysis does not check exported functions #65401 (closed)
• x/tools/gopls: Error loading workspace folders (expected 1, got 0) #44122 (closed)
• x/tools/gopls: placeholder still exists when `usePlaceholders` is false #62676 (closed)
• x/tools/gopls: panic and crash in golang.org/x/telemetry/internal/counter #64577 (closed)
• x/tools/gopls: configuration ignored #65519 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[adonovan]

This seems more likely to be a problem with neovim than with gopls. Can you record the LSP session between your client and the server, and look for workspace/configuration within it? It should show the requested value and confirmation of that value in the response.

Which of those settings were you expecting to see reflected in the behavior that you did not see? If it was fieldalignment, you should be aware that that setting is a legacy that merely emits a warning but otherwise has no effect.

[OneOfOne]

was expecting fillreturns = false to work, how do I record the lsp session?

[OneOfOne]

[Trace - 15:30:32.911 PM] Sending notification 'workspace/didChangeConfiguration'.
Params: {"settings":{"gopls":{"completeUnimported":true,"usePlaceholders":false,"staticcheck":true,"hints":{"parameterNames":true,"rangeVariableTypes":true,"functionTypeParameters":true,"constantValues":true,"compositeLiteralTypes":true,"compositeLiteralFields":true,"assignVariableTy
pes":true},"directoryFilters":["-.git","-.vscode","-.idea","-.vscode-test","-node_modules"],"codelenses":{"upgrade_dependency":true,"tidy":true,"run_govulncheck":true,"regenerate_cgo":true,"generate":true,"gc_details":false,"vendor":true,"test":true},"gofumpt":true,"analyses":{"nilne
ss":true,"useany":true,"unusedparams":true,"fillreturns":false,"unusedwrite":true,"fieldalignment":true},"semanticTokens":true,"completeFunctionCalls":false}}}

[adonovan]

Thanks, that confirms that it's not a client configuration issue. So what exactly are you observing that you didn't expect?

Are you still seeing fillreturns quick-fixes offered on ill-typed code such as this?

func b() (string, int, error) {
	return "", errors.New("")
}

[OneOfOne]

func b() (s string, i int, e error) {
	return s, i, e
       // should be just return
}

[adonovan]

Sorry, I can't from the previous comment what you did, what you expected, and what you saw.

[OneOfOne]

I expected it to just have return, instead it appends the variable names return s, l, e

func b() (s string, i int, e error) {
        // unexpected
	return s, i, e
}

func b() (s string, i int, e error) {
        // expected
	return
}

[adonovan]

What did you actually do?

[OneOfOne]

Just saved the file and it automatically formatted it like that.

[adonovan]

But what was in the file? It would really help if you could take just a moment to explain yourself clearly.