Skip to content

x/tools/gopls/internal/cmd: TestDefinition failures #76514

@gopherbot

Description

@gopherbot
#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestDefinition"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestDefinition
=== PAUSE TestDefinition
=== CONT  TestDefinition
    integration_test.go:291: gopls definition a.go:7:2: exited with code 2, want success: true (gopls definition a.go:7:2: exit=2 stdout=<<./a.go:3:6-7: defined here as func f()
        >> stderr=<<panic: surplus bytes
        
        goroutine 1084 [running]:
        golang.org/x/tools/gopls/internal/util/frob.(*frob).Decode(0x3f17b60ff470, {0x3f17bdc7c600, 0x8, 0x200}, {0x101a27b60?, 0x3f17bd4234f8?})
        	/Users/swarming/.swarming/w/ir/x/w/targetrepo3325812423/gopls/internal/util/frob/frob.go:252 +0x194
        golang.org/x/tools/gopls/internal/util/frob.Codec[...].Decode(...)
...
        golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached(0x658ed0ff22c0, {0x103b42710, 0x658ed1816390}, {0x92, 0x77, 0xc4, 0x58, 0x41, 0x82, 0xdc, ...})
        	/Users/swarming/.swarming/w/ir/x/w/targetrepo3325812423/gopls/internal/cache/analysis.go:588 +0x1d0
        golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
        	/Users/swarming/.swarming/w/ir/x/w/targetrepo3325812423/gopls/internal/cache/analysis.go:340 +0x3f4
        golang.org/x/sync/errgroup.(*Group).Go.func1()
        	/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.17.0/errgroup/errgroup.go:93 +0x4c
        created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 1107
        	/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.17.0/errgroup/errgroup.go:78 +0x98
        >>)
--- FAIL: TestDefinition (4.00s)

watchflakes

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Projects

    Status

    Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions