Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: data race in BenchmarkTCP6OneShotTimeout #7718

Closed
dvyukov opened this issue Apr 6, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@dvyukov
Copy link
Member

commented Apr 6, 2014

There are lots of races in various TCP benchmarks on bots recently:

BenchmarkTCP6OneShotTimeout-4       1000        307762 ns/op
==================
WARNING: DATA RACE
Read by main goroutine:
  testing.RunBenchmarks()
      /Users/builder/workspace/darwin-amd64-race-cheney-1b80f9a5165b/go/src/pkg/testing/benchmark.go:325 +0xa89
  testing.Main()
      /Users/builder/workspace/darwin-amd64-race-cheney-1b80f9a5165b/go/src/pkg/testing/testing.go:443 +0x237
  main.main()
      /var/folders/q5/9m80sxt95q19qcx8r96_vqlr0000gp/T/go-build520565622/net/_test/_testmain.go:331 +0xdc

Previous write by goroutine 35:
  testing.(*common).log()
      /Users/builder/workspace/darwin-amd64-race-cheney-1b80f9a5165b/go/src/pkg/testing/testing.go:311 +0x232
  testing.(*common).Logf()
      /Users/builder/workspace/darwin-amd64-race-cheney-1b80f9a5165b/go/src/pkg/testing/testing.go:322 +0x7e
  net.func·076()
      /Users/builder/workspace/darwin-amd64-race-cheney-1b80f9a5165b/go/src/pkg/net/tcp_test.go:79 +0x19b
  net.func·081()
      /Users/builder/workspace/darwin-amd64-race-cheney-1b80f9a5165b/go/src/pkg/net/tcp_test.go:141 +0x45c
  runtime.gosched0()
      /Users/builder/workspace/darwin-amd64-race-cheney-1b80f9a5165b/go/src/pkg/runtime/proc.c:1417 +0xaf
  net.(*pollDesc).PrepareRead()
      /Users/builder/workspace/darwin-amd64-race-cheney-1b80f9a5165b/go/src/pkg/net/fd_poll_runtime.go:76 +0x4f
  net.(*netFD).Read()
      /Users/builder/workspace/darwin-amd64-race-cheney-1b80f9a5165b/go/src/pkg/net/fd_unix.go:224 +0x10a
  net.(*conn).Read()
      /Users/builder/workspace/darwin-amd64-race-cheney-1b80f9a5165b/go/src/pkg/net/net.go:122 +0x11f
  net.(*TCPConn).Read()
      /Users/builder/workspace/darwin-amd64-race-cheney-1b80f9a5165b/go/src/pkg/net/dial.go:1 +0x74
  net.func·077()
      /Users/builder/workspace/darwin-amd64-race-cheney-1b80f9a5165b/go/src/pkg/net/tcp_test.go:86 +0x9e
  net.func·081()
      /Users/builder/workspace/darwin-amd64-race-cheney-1b80f9a5165b/go/src/pkg/net/tcp_test.go:141 +0x4fa
==================

http://build.golang.org/log/805f04d7d9e103e167e4362449329e5ad6853c81
@dvyukov

This comment has been minimized.

Copy link
Member Author

commented Apr 7, 2014

Comment 1:

This issue was updated by revision 8076f21.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/84750047
@dvyukov

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2014

Comment 2:

This issue was closed by revision 9e1cada.

Status changed to Fixed.

@dvyukov dvyukov added fixed labels Apr 8, 2014

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015

@rsc rsc removed the release-go1.3maybe label Apr 14, 2015

@golang golang locked and limited conversation to collaborators Jun 25, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.