Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: add more detail to the error message arising from a missing hash function. #7735

Open
agl opened this issue Apr 9, 2014 · 5 comments
Labels
help wanted NeedsFix

Comments

@agl
Copy link
Contributor

@agl agl commented Apr 9, 2014

If a certificate is signed with a hash function that wasn't compiled in the error
message isn't bad, but could be better:

x509: certificate signed by unknown authority (possibly because of "x509: cannot
verify signature: algorithm unimplemented" while trying to verify candidate
authority certificate "CA Cert Signing Authority")
@rsc
Copy link
Contributor

@rsc rsc commented Sep 15, 2014

Comment 1:

Labels changed: added release-go1.5, removed release-go1.4.

@bradfitz bradfitz added this to the Go1.5 milestone Dec 16, 2014
@bradfitz bradfitz added this to the Go1.5 milestone Dec 16, 2014
@rsc rsc removed accepted labels Apr 14, 2015
@rsc rsc added this to the Unplanned milestone Jul 14, 2015
@rsc rsc removed this from the Go1.5 milestone Jul 14, 2015
@bradfitz bradfitz added this to the Go1.9Maybe milestone Mar 21, 2017
@bradfitz bradfitz removed this from the Unplanned milestone Mar 21, 2017
@bradfitz bradfitz added help wanted NeedsFix labels Mar 21, 2017
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Mar 21, 2017

(More details in closed dup #5301)

@odeke-em
Copy link
Member

@odeke-em odeke-em commented Mar 22, 2017

@agl would the direct error message

x509: cannot verify signature: algorithm unimplemented

suffice? Catch it right after it has occured.
I took a break from studying Chemistry to get something in, I'll now need to compile a test when free, then submit a CL, probably on the weekend, if this is cool with you.

@agl
Copy link
Contributor Author

@agl agl commented Mar 24, 2017

I don't believe that the problem is that the error message is too long, but that it doesn't hint at a solution. I.e. perhaps it could hint that it might be a hash function that's not compiled in.

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 29, 2017

CL https://golang.org/cl/42143 mentions this issue.

@bradfitz bradfitz added this to the Go1.10 milestone Jul 20, 2017
@bradfitz bradfitz removed this from the Go1.9Maybe milestone Jul 20, 2017
@rsc rsc removed this from the Go1.10 milestone Nov 22, 2017
@rsc rsc added this to the Go1.11 milestone Nov 22, 2017
@ianlancetaylor ianlancetaylor removed this from the Go1.11 milestone Jun 29, 2018
@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Jun 29, 2018
@andybons andybons removed this from the Go1.12 milestone Feb 12, 2019
@andybons andybons added this to the Go1.13 milestone Feb 12, 2019
@andybons andybons removed this from the Go1.13 milestone Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted NeedsFix
Projects
None yet
Development

No branches or pull requests

7 participants