New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ssh/terminal: does not handle interruptions #7939

Open
gopherbot opened this Issue May 5, 2014 · 5 comments

Comments

Projects
None yet
5 participants
@gopherbot
Copy link

gopherbot commented May 5, 2014

by monikan@google.com:

go.crypto/ssh/terminal does not handle interruptions. 

Instead of ignoring an interruption terminal should return with error allowing the
caller to handle interruption e.g. restore terminal state before exiting.
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 5, 2014

Comment 1:

CL https://golang.org/cl/93010046 mentions this issue.
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

ianlancetaylor commented May 9, 2014

Comment 2:

Labels changed: added repo-crypto.

@agl

This comment has been minimized.

Copy link
Contributor

agl commented May 10, 2014

Comment 3:

(A callback seems reasonable. Waiting on the code review.)

Owner changed to @agl.

Status changed to WaitingForReply.

@mikioh mikioh changed the title go.crypto/ssh/terminal: does not handle interruptions ssh/terminal: does not handle interruptions Jan 7, 2015

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc removed the waitingforreply label Apr 14, 2015

@rsc rsc changed the title ssh/terminal: does not handle interruptions x/crypto/ssh/terminal: does not handle interruptions Apr 14, 2015

@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015

@rsc rsc removed the repo-crypto label Apr 14, 2015

@ysmolsky

This comment has been minimized.

Copy link
Member

ysmolsky commented Nov 5, 2018

@andybons it seems that there was a CL from the author of the ticket, but it was abandoned during move to gerrit. I saw many tickets of this kind. What do we do with such tickets? Leave them be or close due age?

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

ianlancetaylor commented Nov 5, 2018

At this point we can ignore old pre-Gerrit CL's. If the author didn't have the time to move the CL to Gerrit, we shouldn't expect anyone else to do the work.

Whether the issue should be closed depends on the issue. It should be closed if it's no longer a problem, kept open if it is. That is, consider the issue without regard to the old CL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment