x/crypto/ssh/terminal: does not handle interruptions

[gopherbot]

by monikan@google.com:

go.crypto/ssh/terminal does not handle interruptions. 

Instead of ignoring an interruption terminal should return with error allowing the
caller to handle interruption e.g. restore terminal state before exiting.

[gopherbot]

Comment 1:

CL https://golang.org/cl/93010046 mentions this issue.

[ianlancetaylor]

Comment 2:

Labels changed: added repo-crypto.

[agl]

Comment 3:

(A callback seems reasonable. Waiting on the code review.)

Owner changed to @agl.

Status changed to WaitingForReply.

[ysmolski]

@andybons it seems that there was a CL from the author of the ticket, but it was abandoned during move to gerrit. I saw many tickets of this kind. What do we do with such tickets? Leave them be or close due age?

[ianlancetaylor]

At this point we can ignore old pre-Gerrit CL's. If the author didn't have the time to move the CL to Gerrit, we shouldn't expect anyone else to do the work.

Whether the issue should be closed depends on the issue. It should be closed if it's no longer a problem, kept open if it is. That is, consider the issue without regard to the old CL.