crypto/tls: aes-gcm nonce data race

[thatnealpatel]

readHandshake calls sendAlertLocked (no lock) from handlePostHandshakeMessage (TLS 1.3).
Concurrent Write goroutine holds c.out.Lock().
Both call writeRecordLocked -> encrypt -> xorNonceAEAD.Seal simultaneously.
Data race on nonce state.

[gopherbot]

Change https://go.dev/cl/779623 mentions this issue: crypto/tls: fix AES-GCM nonce state data race

[gabyhelp]

Related Issues

• crypto/tls: data race accessing Conn.handshakeErr in QUICConn.NextEvent #77274 (closed)
• crypto/tls: conflicting lock order in Handshake() and Read() #38870
• crypto/tls: handshake race between read and write goroutines in go1.7 #17101 (closed)
• crypto/tls: data race on error var #3862 (closed)

Related Code Changes

• crypto/tls: fix AES-GCM nonce state data race

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}