cmd/dist: all.bash does not fail when run.bash fails

[rsc]

I got tired of waiting for all.bash to finish the tests (and one had failed already anyway) so I typed ^C but then it still printed the final banner and exited with a successful status. If the tests are interrupted then dist test should exit non-zero and then all.bash should also exit non-zero. Looking at the scripts I don't see what is wrong. But this is a critical thing to fix. If tests fail then all.bash must not succeed!

ok  	net/internal/socktest	1.492s
ok  	net/mail	1.649s
ok  	net/netip	2.227s
--- FAIL: TestGobError (7.79s)
    client_test.go:61: expected `reading body unexpected EOF', got dial tcp 127.0.0.1:59866: connect: operation timed out
2026/05/20 09:47:36 Test RPC server listening on 127.0.0.1:59912
2026/05/20 09:47:46 Test HTTP RPC server listening on 127.0.0.1:59930
2026/05/20 09:47:46 NewServer test RPC server listening on 127.0.0.1:59932
2026/05/20 09:47:46 rpc.Register: type ReplyNotPointer has no exported methods of suitable type
2026/05/20 09:47:46 rpc.Register: type ArgNotPublic has no exported methods of suitable type
2026/05/20 09:47:46 rpc.Register: type ReplyNotPublic has no exported methods of suitable type
2026/05/20 09:47:46 rpc.Register: type NeedsPtrType has no exported methods of suitable type (hint: pass a pointer to value of that type)
2026/05/20 09:47:46 rpc.Serve: accept:accept tcp 127.0.0.1:59940: use of closed network connection
FAIL
FAIL	net/rpc	19.016s
ok  	net/rpc/jsonrpc	1.832s
ok  	net/smtp	1.535s
ok  	net/textproto	1.534s
ok  	net/url	1.546s
ok  	os	25.309s
ok  	os/exec	1.199s
ok  	os/exec/internal/fdtest	0.780s
^Cgo tool dist: signal: interrupt
---
Installed Go for darwin/arm64 in /Users/rsc/ogo
Installed commands in /Users/rsc/ogo/bin
*** You need to add /Users/rsc/ogo/bin to your PATH.
% 

[dmitshur]

As a baseline, the go test command does return a non-zero exit code on Ctrl+C (SIGINT):

src $ go test all
ok  	archive/tar	(cached)
ok  	archive/zip	(cached)
ok  	bufio	(cached)
^C
src $ echo $?
130

A smaller reproducer for this report:

src $ go tool dist test

##### Test execution environment.
# GOARCH: arm64
# CPU: Apple M1 Pro
# GOOS: darwin
# OS Version: Darwin 24.6.0 Darwin Kernel Version 24.6.0: Fri Feb 27 19:31:41 PST 2026; root:xnu-11417.140.69.709.8~1/RELEASE_ARM64_T6000 arm64

##### Testing packages.
ok  	archive/tar	0.595s
ok  	archive/zip	0.255s
ok  	bufio	0.509s
ok  	bytes	0.702s
ok  	cmp	0.778s
ok  	compress/bzip2	0.938s
^Ccrypto/aes.test: /Users/gopher/gotip/pkg/tool/darwin_arm64/link: signal: interrupt
go tool dist: signal: interrupt
signal: interrupt
FAIL	compress/flate	0.878s
src $ echo $?
0

The problem seems to be introduced at the go tool invocation layer. Invoking dist directly and sending it a SIGINT causes it to exit with a non-zero exit code:

src $ go tool -n dist     
/Users/gopher/Library/Caches/go-build/11/113f38810d9dcf8b5928a6636fb226ec0e978f364f10f90ab156d860d6dc1974-d/dist
src $ GOROOT=$HOME/gotip /Users/gopher/Library/Caches/go-build/11/113f38810d9dcf8b5928a6636fb226ec0e978f364f10f90ab156d860d6dc1974-d/dist test

##### Test execution environment.
# GOARCH: arm64
# CPU: Apple M1 Pro
# GOOS: darwin
# OS Version: Darwin 24.6.0 Darwin Kernel Version 24.6.0: Fri Feb 27 19:31:41 PST 2026; root:xnu-11417.140.69.709.8~1/RELEASE_ARM64_T6000 arm64

##### Testing packages.
ok  	archive/tar	0.438s
ok  	archive/zip	0.355s
ok  	bufio	0.421s
ok  	bytes	0.601s
ok  	cmp	0.665s
ok  	compress/bzip2	0.823s
^C
src $ signal: interrupt
FAIL	compress/flate	1.069s
signal: interrupt
FAIL	compress/gzip	1.028s
echo $?
130
src $ 

Filed issue #79540 with a small reproducer for go tool itself.

This doesn't seem like a recent regression, so it probably doesn't need to block 1.27 specifically, though fixing it would be good. Release testing does use go tool dist test but it's unlikely to be sending it a signal.

[gopherbot]

Change https://go.dev/cl/781100 mentions this issue: cmd/go: return non-zero when go tool is interrupted

[yorukot]

Just checked the issue. I found that the root cause is in the go tool wrapper.

When the child process is interrupted by SIGINT, it does not have a normal exit code, so exec.ExitError.ExitCode
returns -1. The old code passed that -1 to base.SetExitStatus, which leaves the go command status as 0.

So go tool can print "signal: interrupt" but still exit successfully.

I changed it to keep normal non-negative exit codes, and map signal-terminated exits to status 1.

// src/cmd/go/internal/tool/tool.go:422
e, ok := err.(*exec.ExitError)
if !ok || !e.Exited() || cfg.BuildX {
	fmt.Fprintf(os.Stderr, "go tool %s: %s\n", toolName, err)
}
if ok {
	base.SetExitStatus(e.ExitCode())
} else {
	base.SetExitStatus(1)
}

What I did was change it to:

// src/cmd/go/internal/tool/tool.go:422
e, ok := err.(*exec.ExitError)
if !ok || !e.Exited() || cfg.BuildX {
	fmt.Fprintf(os.Stderr, "go tool %s: %s\n", toolName, err)
}
if ok {
	if code := e.ExitCode(); code >= 0 {
		base.SetExitStatus(code)
	} else {
		base.SetExitStatus(1)
	}
} else {
	base.SetExitStatus(1)
}