x/pkgsite: wrong sort order for /v1beta/versions/

[ldez]

What is the URL of the page with the issue?

https://pkg.go.dev/v1beta/api

What is your user agent?

No specific user agent

Screenshot

No response

What did you do?

The documentation about /v1beta/versions/{path} states:

The versions are in descending order.

This works well until the major version is higher than v9.

I think the sort is based on strings and not version numbers.

What did you see happen?

$ curl -L "https://pkg.go.dev/v1beta/versions/github.com/akamai/AkamaiOPEN-edgegrid-golang?limit=1"
{"items":[{"modulePath":"github.com/akamai/AkamaiOPEN-edgegrid-golang/v9","version":"v9.1.0","commitTime":"2024-11-14T13:00:38Z","isRedistributable":true,"hasGoMod":true,"latestVersion":"v9.1.0","deprecated":false,"deprecationReason":"","retracted":false,"retractionReason":""}],"total":104,"nextPageToken":"c265c4d880bde0a38a4e596d218e0b86"}

But the latest major version is v13, not v9.

What did you expect to see?

I expect the major versions to be ordered even if the major version is upper than v9.

[gabyhelp]

Related Issues

• x/website/internal/dl: version sorting doesn't sort pre-release versions #47367 (closed)
• x/pkgsite: mismatch between GetLatestMajorPathForV1Path and getLatestMajorVersion #43849 (closed)
• x/website/internal/dl: provide json listing in version order #50201 (closed)
• x/pkgsite: search redesign - remove module path in "other major versions" #49069 (closed)
• golang.org/x/mod@v0.23.0/semver: semver.Sort is broken #71887 (closed)
• x/pkgsite: grouped search fails to group some modules #47839 (closed)
• x/pkgsite: search ranking ought to prioritize more recent major module versions #36969 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[hyangah]

@jba @ethanalee-work

Version sorting doesn't seem to handle the case correctly where major versions differ.

Assuming that the API is supposed to disallow ambiguous requests, shouldn't the api report ambiguity, or return information about only v0 or v1 modules?

And https://pkg.go.dev/v1beta/versions/github.com/akamai/AkamaiOPEN-edgegrid-golang/v13 returns vN versions where N != 13. That's

[jba]

Yes, the sorting order is wrong because it sorts by module path lexicographically before version. I will address that.

I do think this API should include versions for all major versions, not just v0/1. I think that's the only way to learn about other major versions. We need to doc that better.