x/tools/gopls: invalid conversion of array to array pointer when accepting autocompletion

[gnojus]

What did you do?

Started typing and accepted autocompletion for array (with array variable in place of pointer-to-array argument).

func foo(p *[10]int) {}

func bar() {
	var array [10]int
	foo(arr<cursor>)
}

What did you expect to see?

It autocompletes to either plain array, or to &array like it does with types like int.

What did you see instead?

It autocompletes to (*[10]int)(array), which is wrong and invalid code.

Build info

golang.org/x/tools/gopls v0.22.0
    golang.org/x/tools/gopls@v0.22.0 h1:9aON2mTxKrZ1y71RbQVnlPTTNfKZ9y5cv3x/f6XpsZw=
    github.com/BurntSushi/toml@v1.6.0 h1:dRaEfpa2VI55EwlIW72hMRHdWouJeRF7TPYhI+AUQjk=
    github.com/fatih/camelcase@v1.0.0 h1:hxNvNX/xYBp0ovncs8WyWZrOrpBNub/JfaMvbURyft8=
    github.com/fatih/gomodifytags@v1.17.1-0.20250423142747-f3939df9aa3c h1:dDSgAjoOMp8da3egfz0t2S+t8RGOpEmEXZubcGuc0Bg=
    github.com/fatih/structtag@v1.2.0 h1:/OdNE99OxoI/PqaW/SuSK9uxxT3f/tcSZgon/ssNSx4=
    github.com/fsnotify/fsnotify@v1.9.0 h1:2Ml+OJNzbYCTzsxtv8vKSFD9PbJjmhYF14k/jKC7S9k=
    github.com/google/go-cmp@v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
    github.com/google/jsonschema-go@v0.4.2 h1:tmrUohrwoLZZS/P3x7ex0WAVknEkBZM46iALbcqoRA8=
    github.com/modelcontextprotocol/go-sdk@v1.4.0 h1:u0kr8lbJc1oBcawK7Df+/ajNMpIDFE41OEPxdeTLOn8=
    github.com/segmentio/asm@v1.2.1 h1:DTNbBqs57ioxAD4PrArqftgypG4/qNpXoJx8TVXxPR0=
    github.com/segmentio/encoding@v0.5.3 h1:OjMgICtcSFuNvQCdwqMCv9Tg7lEOXGwm1J5RPQccx6w=
    github.com/yosida95/uritemplate/v3@v3.0.2 h1:Ed3Oyj9yrmi9087+NczuL5BwkIc4wvTb5zIM+UJPGz4=
    golang.org/x/exp/typeparams@v0.0.0-20260312153236-7ab1446f8b90 h1:cfW8UCYSVdPblxA7qQe3o5Iad55Vsx4BFmuGS9RNOmc=
    golang.org/x/mod@v0.35.0 h1:Ww1D637e6Pg+Zb2KrWfHQUnH2dQRLBQyAtpr/haaJeM=
    golang.org/x/oauth2@v0.36.0 h1:peZ/1z27fi9hUOFCAZaHyrpWG5lwe0RJEEEeH0ThlIs=
    golang.org/x/sync@v0.20.0 h1:e0PTpb7pjO8GAtTs2dQ6jYa5BWYlMuX047Dco/pItO4=
    golang.org/x/sys@v0.43.0 h1:Rlag2XtaFTxp19wS8MXlJwTvoh8ArU6ezoyFsMyCTNI=
    golang.org/x/telemetry@v0.0.0-20260409153401-be6f6cb8b1fa h1:efT73AJZfAAUV7SOip6pWGkwJDzIGiKBZGVzHYa+ve4=
    golang.org/x/text@v0.36.0 h1:JfKh3XmcRPqZPKevfXVpI1wXPTqbkE5f7JA92a55Yxg=
    golang.org/x/tools@v0.44.1-0.20260513175300-635ae9663724 h1:rz7KAMVmPA+7ecCT/BHKLE353MUOoCAwMqlUveE8508=
    golang.org/x/vuln@v1.1.4 h1:Ju8QsuyhX3Hk8ma3CesTbO8vfJD9EvUBgHvkxHBzj0I=
    honnef.co/go/tools@v0.7.0 h1:w6WUp1VbkqPEgLz4rkBzH/CSU6HkoqNLp6GstyTx3lU=
    mvdan.cc/gofumpt@v0.9.2 h1:zsEMWL8SVKGHNztrx6uZrXdp7AX8r421Vvp23sz7ik4=
    mvdan.cc/xurls/v2@v2.6.0 h1:3NTZpeTxYVWNSokW3MKeyVkz/j7uYXYiMtXRUfmjbgI=
go: go1.26.0-X:simd

[gabyhelp]

Related Issues

• x/tools/gopls: completion of array pointer assignment to element-typed variable results in incorrect dereferencing #76202
• x/tools/gopls: poor / invalid import suggestions #76310 (closed)
• x/tools/gopls: returns invalid comment on hover #79146 (closed)
• x/tools/gopls: hover: doc links to pointers are not formatted correctly #77329 (closed)
• x/tools/gopls: Completion of generic argument resulting in invalid casting to constraints #75469 (closed)
• x/tools/gopls: importing wrong package "golang.org/x/exp/slices" #63641 (closed)
• go/types: panic when checking self-referential generic type alias #77640 (closed)
• x/tools/gopls: bad type parameters from code action to declare missing interface methods #79845 (closed)
• x/tools/gopls: Definition: does not treat doc link followed by colon as a reference #75925 (closed)
• x/tools/gopls: #52425 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/799560 mentions this issue: gopls/internal/completion: fix issue 80268