-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/internal/obj/x86: add fma #8037
Comments
Were the compiler to add and begin to support this feature, the Daxpy function in https://github.com/gonum/blas/blob/master/goblas/level1double.go is a good place to start. |
CL https://golang.org/cl/18850 mentions this issue. |
Generated by x86test, from https://golang.org/cl/18842 (still in progress). The commented out lines are either missing or misspelled or incorrectly handled instructions. For #4816, #8037, #13822, #14068, #14069. Change-Id: If309310c97d9d2a3c71fc64c51d4a957e9076ab7 Reviewed-on: https://go-review.googlesource.com/18850 Reviewed-by: Rob Pike <r@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Is there documentation for how to add commands to the assembler? This documentation says that the process is straightforward, and even describes how to use unsupported instructions with known opcodes. |
@odysseus9672 I don't think there is any documentation, but you can follow other CLs that added instructions (e.g. https://go-review.googlesource.com/c/14127/). git blame will give you a more comprehensive list. |
@randall77, planning on doing this for Go 1.10? |
If the compiler is to emit these, I think this would require a GOAMD64, since FMA is not part of the minimum supported amd64 instruction set: #19593 |
Implemented in https://go-review.googlesource.com/#/c/go/+/75490/. |
@randall77 - Given that we have an FMA function now, should this be closed ? Automatically generating FMA instructions might need to bump our minimum architecture set. |
Yes, I think this is just about the assembly instructions, which were added in CL 75490. We do already generate these special assembly instructions for math.FMA on AMD64. They are guarded by a runtime cpu feature detection test. |
by odysseus9672:
The text was updated successfully, but these errors were encountered: