Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: a timeout error on tls.Conn.Write is confusing #8071

Open
mikioh opened this issue May 22, 2014 · 3 comments

Comments

Projects
None yet
5 participants
@mikioh
Copy link
Contributor

commented May 22, 2014

SetWriteDeadline of tls.Conn describes "A zero value for t means Write will not
time out. After a Write has timed out, the TLS state is corrupt and all future writes
will return the same error." but the returned value on timeout is marked Temporary
and it may be confusing.

A suggestion: https://groups.google.com/d/msg/golang-nuts/UChb8wv6gvA/9R_g4ScTMiYJ
@griesemer

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

Comment 1:

Labels changed: added release-none, repo-crypto.

@mikioh mikioh added new labels Oct 1, 2014

@bradfitz bradfitz removed the new label Dec 18, 2014

@mikioh mikioh added repo-main and removed repo-crypto labels Jan 7, 2015

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc removed release-none labels Apr 10, 2015

@ysmolsky

This comment has been minimized.

Copy link
Member

commented Nov 6, 2018

The description in this issue is somewhat confusing. What is exactly proposed here?

@mikioh

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2018

The description in this issue is somewhat confusing.

Hm, I have never imagined it's confusing.

What is exactly proposed here?

My understanding from the discussion at golang-nuts is that the returned error value from tls.Conn should not be marked/colored "Temporary" when the underlying facilities are unable to provide communication functionality anymore.

In other words, a returned error value should represent the error, the definition is slightly different between SDOs, let's say it's "an incorrect internal state" here, precisely as much as possible for fault localization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.