Since issue #80309 was fixed, once users start using gopls v0.24.0, the client they use will need to correctly send the following client capabilities:
textDocument.semanticTokens.tokenTypes
textDocument.semanticTokens.tokenModifiers
As mentioned in #80309, the LSP expects that clients set these fields if they support semantic tokens, as it the two capabilities denote the maximal set of token/modifier types the server should return to the client. Since other language servers probably do enforce this client capability, I don't expect this to be an issue.
But since gopls didn't previously, its possible that some clients didn't think it was necessary. So this issue is just to make sure we preemptively go through popular client's capabilities to prevent any regressions.
Popular clients:
Since issue #80309 was fixed, once users start using gopls v0.24.0, the client they use will need to correctly send the following client capabilities:
textDocument.semanticTokens.tokenTypestextDocument.semanticTokens.tokenModifiersAs mentioned in #80309, the LSP expects that clients set these fields if they support semantic tokens, as it the two capabilities denote the maximal set of token/modifier types the server should return to the client. Since other language servers probably do enforce this client capability, I don't expect this to be an issue.
But since gopls didn't previously, its possible that some clients didn't think it was necessary. So this issue is just to make sure we preemptively go through popular client's capabilities to prevent any regressions.
Popular clients: