os: Chtimes doesn't work on directory on Windows

[gopherbot]

by victorvu2001:

What does 'go version' print?
go version go1.2.2 windows/amd64

Calling os.Chtimes() with a directory as an argument fails on Windows (Win8.1 64bit)
with a "Access is denied." error. This happens even if the directory exists
and all write permissions are properly set.

[gopherbot]

Comment 1 by victorvu2001:

Update.
I did some digging, and the root cause seems to be in the CreateFile() call in
UtimesNano() (pkg/syscall/syscall_windows.go), specifically its use of
FILE_ATTRIBUTE_NORMAL for the dwFlagsAndAttributes parameter.
The docs for CreateFile [1] say that FILE_FLAG_BACKUP_SEMANTICS must be set to obtain a
handle to a directory. It also says that opening an existing file "ignores any file
attributes" specified, so FILE_ATTRIBUTE_NORMAL is useless.
Possible fix? https://gist.github.com/vqvu/d8332f7ce87e13879e5d
[1] http://msdn.microsoft.com/en-us/library/windows/desktop/aa363858%28v=vs.85%29.aspx

[ianlancetaylor]

Comment 2:

Labels changed: added repo-main, release-go1.4, os-windows.

[alexbrainman]

Comment 3:

Sounds like a plan. Here http://golang.org/doc/contribute.html is how to contribute, if
you like. Also, please, add new test that is broken now, but will be fixed once your
change is applied. Thank you.
Alex

Status changed to Accepted.

[gopherbot]

Comment 4:

CL https://golang.org/cl/154020043 mentions this issue.

[rsc]

Comment 5:

This issue was closed by revision ab724f9.

Status changed to Fixed.