Skip to content

crypto/tls: use ChaCha8 source during benchmarks #81344

Open

Description

@rhysh

Follow up to CL 780102 for the Go 1.28 cycle, in the form of an issue so it can be tracked.

I mailed CL 780102 in response to a break in the crypto/tls benchmarks (#79468, #79521, and #79522) late in the Go 1.27 cycle. That CL used all zeroes for the entropy source for those benchmarks, which worked for the Go 1.27 release but isn't a good long-term strategy. They should use a Reader that doesn't give a trivial pattern; ChaCha8 with a fixed seed would work. CL 779984 implements that.

CC @golang/security @FiloSottile @thatnealpatel

Activity

  1. added this to the Go1.28 milestone on Sep 3, 2026
  2. gabyhelp commented on Sep 3, 2026

    @gabyhelp

    Related Code Changes

    (Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

  3. added
    NeedsDecisionFeedback is required from experts, contributors, and/or the community before a change can be made.
    on Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsDecisionFeedback is required from experts, contributors, and/or the community before a change can be made.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions