Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: TestOverflowRuntimeTimer failing #8136

Closed
gpaul opened this issue Jun 2, 2014 · 5 comments
Closed

time: TestOverflowRuntimeTimer failing #8136

gpaul opened this issue Jun 2, 2014 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@gpaul
Copy link
Contributor

gpaul commented Jun 2, 2014 

Please merge this into issue #6874 and reopen it.

go version go1.3beta2 +177ed19da89f Wed May 28 14:04:31 2014 -0400 linux/amd64

What steps reproduce the problem?
If possible, include a link to a program on play.golang.org.

This failure is reproduced quickly by running this script.

-----------
#!/bin/sh
set -xe
go test -c -i time
while /bin/true
do
    GOMAXPROCS=$[ 1 + $[ RANDOM % 256 ] ]
    ./time.test -test.v
done 
-----------

What happened?
=== RUN TestOverflowRuntimeTimer-251
--- FAIL: TestOverflowRuntimeTimer-251 (0.10 seconds)
    sleep_test.go:391: runtime timer stuck: overflow in addtimer

What should have happened instead?
=== RUN TestOverflowRuntimeTimer-251
--- PASS: TestOverflowRuntimeTimer-251 (0.01 seconds)

Please provide any additional information below.
uname -a
Linux mybox 3.6.11-4.fc16.x86_64 #1 SMP Tue Jan 8 20:57:42 UTC 2013 x86_64 x86_64 x86_64
GNU/Linux
@gpaul
Copy link
Contributor Author

gpaul commented Jun 2, 2014

Comment 1:

This also fails on the latest release-branch.go1.3:
go version go1.3rc1 linux/amd64

@ianlancetaylor
Copy link
Contributor

Comment 2:

Labels changed: added repo-main, release-go1.3maybe.

@ianlancetaylor
Copy link
Contributor

Comment 3:

Actually, resetting this to Go 1.4.  It appears to indicate a problem with the test
rather than an actual problem with the package.

Labels changed: added release-go1.4, removed release-go1.3maybe.

@gopherbot
Copy link

Comment 4:

CL https://golang.org/cl/105140043 mentions this issue.

@robpike
Copy link
Contributor

robpike commented Jun 12, 2014

Comment 5:

This issue was closed by revision 83c8140.

Status changed to Fixed.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@robpike @wheatman
time: avoid broken fix for buggy TestOverflowRuntimeTimer
f990334 
The test requires that timerproc runs, but busy loops and starves
the scheduler so that, with high probability, timerproc doesn't run.
Avoid the issue by expecting the test to succeed; if not, a major
outside timeout will kill it and let us know.

As you can see from the diffs, there have been several attempts to
fix this with chicanery, but none has worked. Don't bother trying
any more.

Fixes golang#8136.

LGTM=rsc
R=rsc, josharian
CC=golang-codereviews
https://golang.org/cl/105140043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
5 participants
@gpaul @rsc @ianlancetaylor @robpike @gopherbot