Repository navigation
cmd/go: data race on Action.buildID between updateBuildID and tryCacheWithID with -coverpkg #81366
Closed as duplicate
Description
#!watchflakes
default <- pkg == "cmd/go" && test == "TestScript/cover_dot_import"
Issue created automatically to collect these failures.
Example (log):
=== RUN TestScript/cover_dot_import
=== PAUSE TestScript/cover_dot_import
=== CONT TestScript/cover_dot_import
script_test.go:141: 2026-09-04T22:28:05Z
script_test.go:143: $WORK=/Users/swarming/.swarming/w/ir/x/t/cmd-go-test-3827900000/tmpdir921171203/cover_dot_import548104553
script_test.go:165:
PATH=/Users/swarming/.swarming/w/ir/x/t/cmd-go-test-3827900000/tmpdir921171203/testbin:/Users/swarming/.swarming/w/ir/x/w/goroot/bin:/Users/swarming/.swarming/w/ir/x/w/goroot/bin:/Users/swarming/.swarming/w/ir/x/w/goroot/bin:/Users/swarming/.swarming/w/ir/cache/tools/bin:/Users/swarming/.swarming/w/ir/bbagent_utility_packages:/Users/swarming/.swarming/w/ir/bbagent_utility_packages/bin:/Users/swarming/.swarming/w/ir/cipd_bin_packages:/Users/swarming/.swarming/w/ir/cipd_bin_packages/bin:/Users/swarming/.swarming/w/ir/cache/cipd_client:/Users/swarming/.swarming/w/ir/cache/cipd_client/bin:/Users/swarming/.swarming/cipd_cache/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/sbin
HOME=/no-home
CCACHE_DISABLE=1
GOARCH=arm64
...
cmd/go.Main()
/Users/swarming/.swarming/w/ir/x/w/goroot/src/cmd/go/export_test.go:7 +0x1af4
cmd/go_test.TestMain()
/Users/swarming/.swarming/w/ir/x/w/goroot/src/cmd/go/go_test.go:156 +0x1af0
main.main()
_testmain.go:168 +0xf8
==================
Found 1 data race(s)
script_test.go:165: FAIL: testdata/script/cover_dot_import.txt:3: go test -coverpkg=coverdot/a,coverdot/b coverdot/b: exit status 66
--- FAIL: TestScript/cover_dot_import (1.83s)
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
gopherbot commentedon Sep 5, 2026
Found new dashboard test flakes for:
2026-09-04 21:47 gotip-darwin-arm64-race go@cc740a9f cmd/go.TestScript/cover_dot_import (log)
— watchflakes
[-]cmd/go: TestScript/cover_dot_import failures[/-][+]cmd/go: data race on Action.buildID between updateBuildID and tryCacheWithID with -coverpkg[/+]JunyangShao commentedon Sep 11, 2026
@golang/go-command
gopherbot commentedon Sep 18, 2026
Found new dashboard test flakes for:
2026-09-18 15:40 gotip-darwin-arm64-race go@0ac819d3 cmd/go.TestScript/cover_dot_import (log)
— watchflakes
thepudds commentedon Sep 22, 2026
This data race seemed to bisect to 33e66cf:
It seemed to reproduce more frequently with
GOMAXPROCS=2. It's a flake, so maybe the bisect went sideways, but a simple sanity check seemed to reproduce the first bad / good parent finding.CC @ryancurrah @matloob
gopherbot commentedon Oct 3, 2026
Found new dashboard test flakes for:
2026-10-02 21:31 gotip-darwin-arm64-race go@bfc1e317 cmd/go.TestScript/cover_dot_import (log)
— watchflakes
gopherbot commentedon Oct 6, 2026
Found new dashboard test flakes for:
2026-10-05 19:28 gotip-darwin-arm64-race go@fe9d9239 cmd/go.TestScript/cover_dot_import (log)
— watchflakes
gopherbot commentedon Oct 7, 2026
Found new dashboard test flakes for:
2026-10-06 23:08 gotip-darwin-arm64-race go@ae7a18d9 cmd/go.TestScript/cover_dot_import (log)
— watchflakes
gopherbot commentedon Oct 9, 2026
Found new dashboard test flakes for:
2026-10-08 22:17 gotip-darwin-arm64-race go@6b5417f0 cmd/go.TestScript/cover_dot_import (log)
— watchflakes
gopherbot commentedon Oct 9, 2026
Found new dashboard test flakes for:
2026-10-09 01:32 gotip-darwin-arm64-race go@b1fde0a2 cmd/go.TestScript/cover_dot_import (log)
— watchflakes
ryancurrah commentedon Oct 9, 2026
I might have some time this weekend to take a look at it.
ryancurrah commentedon Oct 11, 2026
Im unable to reproduce the race condition locally it could be my slow hardware/laptop.
I have a CR here https://go-review.googlesource.com/c/go/+/847669 not sure how to run the race tests in CI against it.
thepudds commentedon Oct 15, 2026
This might be a duplicate of #81327 and perhaps fixed by https://go.dev/cl/847669.
Optimistically closing.