Repository navigation
x/tools/gopls: respect directoryFilters in filewatcher #81630
Description
I've been using gopls.fileWatcher=fsnotify for my LSP usage of gopls since it was added.
It seems to work great. But I have had to carry a local patch that that includes node_modules in skipDir, otherwise I run out of file descriptors.
I think #76291 is related, for MCP usage.
Would be nice if gopls.directoryFilters was respected in the filewatcher machinery as it already includes -**/node_modules by default.
There is a TODO in the code for this.
Activity
gabyhelp commentedon Sep 21, 2026
Related Issues
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)
danp commentedon Sep 21, 2026
(maybe this is still considered to be part of #67995)
[-]gopls/internal/filewatcher: respect directoryFilters[/-][+]x/tools/gopls: respect directoryFilters in filewatcher[/+]h9jiang commentedon Sep 28, 2026
It requires a little bit more change as the file watcher today statically determines the dir it watches, and the gopls setting can be changed after LSP session start. So we need to have the support for
We are releasing v0.24.0 very soon so v0.25.0 will be a reasonable timeline for fix. I will let you know once finished so you can give it a try by install gopls from @master. @danp
Thank you so much for raising this.