Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: handle embedded fields in structtags check #8205

Open
josharian opened this issue Jun 14, 2014 · 3 comments
Open

cmd/vet: handle embedded fields in structtags check #8205

josharian opened this issue Jun 14, 2014 · 3 comments
Milestone

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Jun 14, 2014

The change at https://code.google.com/p/go/source/detail?r=dfa149f4c2fc&;repo=tools
may need to be updated after issue #7363 is resolved.

Marking Go1.4 to match issue #7363.
@rsc
Copy link
Contributor

@rsc rsc commented Sep 15, 2014

Comment 1:

Labels changed: added release-go1.5, removed release-go1.4.

@bradfitz bradfitz added this to the Go1.5 milestone Dec 16, 2014
@bradfitz bradfitz added this to the Go1.5 milestone Dec 16, 2014
@rsc rsc removed accepted labels Apr 14, 2015
@rsc rsc changed the title cmd/vet: update structtags check after issue 7363 is resolved x/tools/cmd/vet: update structtags check after issue 7363 is resolved Apr 14, 2015
@rsc rsc added this to the Unreleased milestone Apr 14, 2015
@rsc rsc removed this from the Go1.5 milestone Apr 14, 2015
@rsc rsc removed the repo-tools label Apr 14, 2015
@dominikh
Copy link
Member

@dominikh dominikh commented Nov 29, 2016

What's the status of this issue? The two referenced issues are closed and Go 1.4 has long passed.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 29, 2016

The change that @josharian is referring to is https://golang.org/cl/91010047 (this is why you should also use CL numbers, not specific revision references).

As far as I can see nothing has changed, and this issue has not been addressed. Currently the test ignores embedded types. It should probably walk through the fields of embedded types recursively.

@ianlancetaylor ianlancetaylor changed the title x/tools/cmd/vet: update structtags check after issue 7363 is resolved cmd/vet: update structtags check for issue 7363 Nov 29, 2016
@ianlancetaylor ianlancetaylor added this to the Go1.9 milestone Nov 29, 2016
@ianlancetaylor ianlancetaylor removed this from the Unreleased milestone Nov 29, 2016
@rsc rsc changed the title cmd/vet: update structtags check for issue 7363 cmd/vet: handle embedded fields in structtags check Jun 22, 2017
@rsc rsc added this to the Go1.10 milestone Jun 22, 2017
@rsc rsc removed this from the Go1.9 milestone Jun 22, 2017
@rsc rsc removed this from the Go1.10 milestone Nov 22, 2017
@rsc rsc added this to the Go1.11 milestone Nov 22, 2017
@gopherbot gopherbot removed this from the Go1.11 milestone May 23, 2018
@gopherbot gopherbot added this to the Unplanned milestone May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants