Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort: documentation typos in 1.3 #8326

Closed
gopherbot opened this issue Jul 3, 2014 · 2 comments
Closed

sort: documentation typos in 1.3 #8326

gopherbot opened this issue Jul 3, 2014 · 2 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 3, 2014

by shawn.milo:

siftDown comments, mismatched brackets: [)
    // siftDown implements the heap property on data[lo, hi). 

symMerge comments: mismatched capitalization:
    SymMerge in comments, symMerge in signature

rotate comments: mismatched capitalization:
    Rotate (twice) in comments, rotate in signature
@MichaelTJones
Copy link
Contributor

@MichaelTJones MichaelTJones commented Jul 3, 2014

Comment 1:

On Thu, Jul 3, 2014 at 2:58 PM, <go@googlecode.com> wrote:
siftDown comments, mismatched brackets: [)
    // siftDown implements the heap property on data[lo, hi).
When I looked at this code I took it to be a half-open interval.
[a, b)  meaning a <= k < b
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jul 5, 2014

Comment 2:

The documentation usually uses correct capitalization even when it forces an unexported
name to be capitalized.  This is OK as these comments do not appear in godoc.
Michael is correct about the half-open interval
(http://en.wikipedia.org/wiki/Interval_(mathematics) ).

Status changed to WorkingAsIntended.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.