Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/json: Comment for Marshal function is out of date. #8342

Closed
bcmills opened this issue Jul 8, 2014 · 4 comments
Closed

encoding/json: Comment for Marshal function is out of date. #8342

bcmills opened this issue Jul 8, 2014 · 4 comments
Assignees
@adg
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Jul 8, 2014 

http://golang.org/pkg/encoding/json/#Marshal says:
> InvalidUTF8Error will be returned if an invalid UTF-8 sequence is encountered.

But http://golang.org/pkg/encoding/json/#InvalidUTF8Error says:
> As of Go 1.2, Marshal instead coerces the string to valid UTF-8 by replacing
invalid bytes with the Unicode replacement rune U+FFFD.


The comment for Marshal should be updated to reflect that InvalidUTF8Error is no longer
returned.
@ianlancetaylor

This comment has been minimized.

Sign in to view
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jul 8, 2014

Comment 1:

Labels changed: added repo-main, release-go1.4.

Status changed to Accepted.
@adg

This comment has been minimized.

Sign in to view
Copy link
Contributor

@adg adg commented Aug 7, 2014

Comment 2:

Owner changed to @adg.

Status changed to Started.
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Aug 7, 2014

Comment 3:

CL https://golang.org/cl/122180043 mentions this issue.
@adg

This comment has been minimized.

Sign in to view
Copy link
Contributor

@adg adg commented Aug 7, 2014

Comment 4:

This issue was closed by revision 77a8dca.

Status changed to Fixed.
@bcmills bcmills added fixed labels Aug 7, 2014
@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@adg @wheatman
encoding/json: document coercion of invalid UTF-8 characters
7bb8e88 
Fixes golang#8342.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/122180043
wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@adg @wheatman
encoding/json: document coercion of invalid UTF-8 characters
fa6e12d 
Fixes golang#8342.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/122180043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adg adg

Labels
FrozenDueToAge
Projects
None yet
Milestone
  Go1.4
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@bcmills @ianlancetaylor @adg @gopherbot @rsc
You can’t perform that action at this time.