-
Notifications
You must be signed in to change notification settings - Fork 18k
mime: TypeByExtension is case sensitive #8350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
rfc2045: " The type, subtype, and parameter names are not case sensitive. For example, TEXT, Text, and TeXt are all equivalent top-level media types. Parameter values are normally case sensitive, but sometimes are interpreted in a case-insensitive fashion, depending on the intended use. (For example, multipart boundaries are case-sensitive, but the "access-type" parameter for message/External-body is not case-sensitive.) The rest of the rfc details in the bnf grammar which comparisons are case sensitive and which are not. Labels changed: added release-none, repo-main. Status changed to Accepted. |
File extension is not strictly defined in any specification but in some other widely-used language / platform it's case insensitive. apache http://httpd.apache.org/docs/current/mod/mod_mime.html "The extension argument is case-insensitive" python https://docs.python.org/2/library/mimetypes.html "type suffixes are first tried case sensitively, then case insensitively" |
CL https://golang.org/cl/127380043 mentions this issue. |
If anything, I think we should do what Python does in comment #5. That doesn't appear to be what Patchset 3 of https://golang.org/cl/127380043 implements. |
This issue was closed by revision af12dc5. Status changed to Fixed. |
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
Fixes golang#8350. LGTM=bradfitz R=golang-codereviews, bradfitz, dave CC=golang-codereviews https://golang.org/cl/127380043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
Fixes golang#8350. LGTM=bradfitz R=golang-codereviews, bradfitz, dave CC=golang-codereviews https://golang.org/cl/127380043
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: