runtime: nacl/amd64p32 build broken by map change

[davecheney]

The nacl/amd64p32 builder broke after the map transition from C to Go.

# Testing packages.
NaClMain flag redefined: test.short
panic: NaClMain flag redefined: test.short

goroutine 1 [running]:
runtime.panic(0x186400, 0x10722160)
    /tmp/gobuilder/nacl-amd64p32-27de92961f3e/go/src/pkg/runtime/panic.c:279 +0x120
flag.(*FlagSet).Var(0x10718120, 0xfefd02a8, 0x1072815d, 0x1c9418, 0xa, 0x1e0d68, 0x23,
0x3629)
    /tmp/gobuilder/nacl-amd64p32-27de92961f3e/go/src/pkg/flag/flag.go:677 +0x400
flag.(*FlagSet).BoolVar(0x10718120, 0x1072815d, 0x1c9418, 0xa, 0x1e1500, 0x1e0d68, 0x23,
0x10728140)
    /tmp/gobuilder/nacl-amd64p32-27de92961f3e/go/src/pkg/flag/flag.go:450 +0xa0
flag.(*FlagSet).Bool(0x10718120, 0x1c9418, 0xa, 0x0, 0x1e0d68, 0x23, 0x1072814a, 0x3629)
    /tmp/gobuilder/nacl-amd64p32-27de92961f3e/go/src/pkg/flag/flag.go:463 +0xa0
flag.Bool(0x1c9418, 0xa, 0x3b9aca00, 0x1e0d68, 0x23, 0x27, 0x1072814a, 0xfeefffc8)
    /tmp/gobuilder/nacl-amd64p32-27de92961f3e/go/src/pkg/flag/flag.go:470 +0x80
testing.init()
    /tmp/gobuilder/nacl-amd64p32-27de92961f3e/go/src/pkg/testing/testing.go:141 +0x360
cmd/addr2line.init()
    /tmp/gobuilder/nacl-amd64p32-27de92961f3e/go/src/cmd/addr2line/addr2line_test.go:116 +0x80
main.init()
    cmd/addr2line/_test/_testmain.go:48 +0x80

goroutine 2 [runnable]:
runtime.MHeap_Scavenger()
    /tmp/gobuilder/nacl-amd64p32-27de92961f3e/go/src/pkg/runtime/mheap.c:507
runtime.goexit()
    /tmp/gobuilder/nacl-amd64p32-27de92961f3e/go/src/pkg/runtime/proc.c:1463

goroutine 3 [runnable]:
bgsweep()
    /tmp/gobuilder/nacl-amd64p32-27de92961f3e/go/src/pkg/runtime/mgc0.c:1942
runtime.goexit()
    /tmp/gobuilder/nacl-amd64p32-27de92961f3e/go/src/pkg/runtime/proc.c:1463

goroutine 4 [runnable]:
runfinq()
    /tmp/gobuilder/nacl-amd64p32-27de92961f3e/go/src/pkg/runtime/mgc0.c:2572
runtime.goexit()
    /tmp/gobuilder/nacl-amd64p32-27de92961f3e/go/src/pkg/runtime/proc.c:1463

Please use labels and text to provide additional information.

This is probably related to amd64p32's unique combination of 64 bit registers but 32bit
pointers and ints.

[gopherbot]

Comment 1 by keith.randall:

Probably an alignment issue.
Anyone have instructions on how to test on nacl?  What do I need installed?
Gut feeling says pkg/runtime/hashmap.go:dataOffset is wrong.  Should be 16 for nacl,
might be 12.

[minux]

Comment 2:

keith, please see http://golang.org/misc/nacl/README on how to setup nacl test
environment.
Basically, you need to extract pepper_38/tools/sel_ldr_x86_64 from 
https://storage.googleapis.com/nativeclient-mirror/nacl/nacl_sdk/trunk.283402/naclsdk_linux.tar.bz2
to your PATH, also
copy $GOROOT/misc/nacl/go_nacl_amd64p32_exec to your PATH.
and then run $GOROOT/src/nacltest.bash.

[davecheney]

Comment 3:

The playground says 16, http://play.golang.org/p/brskhkNvMC, which feels right to me.

[davecheney]

Comment 4:

oh, hang on, I think this is wrong, it should be 12, 8 uint8's plus a *bmap.

[gopherbot]

Comment 5:

CL https://golang.org/cl/114880043 mentions this issue.

[randall77]

Comment 6:

This issue was closed by revision 5035750.

Status changed to Fixed.