Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tour: no way to terminate a snippet that has continued running #8395

Closed
kortschak opened this issue Jul 21, 2014 · 4 comments
Closed

x/tour: no way to terminate a snippet that has continued running #8395

kortschak opened this issue Jul 21, 2014 · 4 comments

Comments

@kortschak
Copy link
Contributor

The Go tour does not provide the same process kill function provided by e.g. present
although the underlying runner can handle these messaged. For the majority of cases this
is not an issue - it is when people are working on the http lessons where the socket
being held by an incorrect but runnable snippet will block later attempts.

The http lesson stubs should probably handle the returned errors (or otherwise prompt
the user that errors are good to check) from ListenAndServe to help users diagnose why a
edited change is not seen when the snippet is re-run.

gotour version: 91f9594fc692+
@ianlancetaylor
Copy link
Contributor

Comment 1:

Labels changed: added repo-tour, release-none.

@campoy
Copy link
Contributor

campoy commented Aug 1, 2014

Comment 2:

Added error handling in https://golang.org/cl/120440043
Working on adding a Kill button to stop running processes.

Status changed to Accepted.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title gotour: currently no way to terminate a snippet that has continued running x/tour: no way to terminate a snippet that has continued running Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-tour label Apr 14, 2015
@kytrinyx
Copy link
Contributor

kytrinyx commented Oct 9, 2015

It looks like there are two things in place to protect against this issue:

  1. The "run" button now turns into a "kill" button
  2. If something takes a long time the program exits with "process took too long"

I think this can be closed.

@adg
Copy link
Contributor

adg commented Oct 9, 2015

Yep, @campoy added a Kill button a while ago.

@adg adg closed this as completed Oct 9, 2015
@golang golang locked and limited conversation to collaborators Oct 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants