Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: mksyscall_windows.go should generate code for non-syscall packages #8398

Closed
alexbrainman opened this issue Jul 21, 2014 · 2 comments
Closed

Comments

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Jul 21, 2014

mksyscall_windows.go generates code for syscall package only. Old mksyscall_windows.pl
script used to generate code for any package. mksyscall_windows.go should do the same.

From https://groups.google.com/forum/#!msg/golang-dev/gyOoSwxBkCA/2octbQGsL7EJ

"...  I understand the perl script has been ported to Go, but last I checked it was
still focused only on generating code for syscall. ..."

Alex
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 21, 2014

Comment 1:

CL https://golang.org/cl/114140043 mentions this issue.
@alexbrainman
Copy link
Member Author

@alexbrainman alexbrainman commented Jul 23, 2014

Comment 2:

This issue was closed by revision 0403181.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
Fixes golang#8398.

LGTM=chines
R=golang-codereviews, chines, josharian
CC=golang-codereviews
https://golang.org/cl/114140043
wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
Fixes golang#8398.

LGTM=chines
R=golang-codereviews, chines, josharian
CC=golang-codereviews
https://golang.org/cl/114140043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.