Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/websocket: Secure Websockets #842

Closed
gopherbot opened this issue Jun 6, 2010 · 2 comments
Closed

x/net/websocket: Secure Websockets #842

gopherbot opened this issue Jun 6, 2010 · 2 comments
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 6, 2010

by kees.varekamp:

Currently wss:// websockets dont work as the websocket.Draft75Handler.ServeHTTP
reconstructs the url as ws:// + ... 

I found that everything works fine when I use a TLS connection and replace line 258 in
go/src/pkg/websocket/server.go:
location := "ws://" + req.Host + req.URL.RawPath
with:
location := "wss://" + req.Host + req.URL.RawPath
@adg
Copy link
Contributor

@adg adg commented Jun 7, 2010

Comment 1:

I suppose it might be worth making this happen automatically.

Labels changed: added packagechange.

Status changed to Thinking.

@rsc
Copy link
Contributor

@rsc rsc commented Sep 11, 2010

Comment 2:

This issue was closed by revision 50e0fb4.

Status changed to Fixed.

@mikioh mikioh added the repo-net label Jan 15, 2015
@mikioh mikioh changed the title Secure Websockets websocket: Secure Websockets Jan 15, 2015
@mikioh mikioh changed the title websocket: Secure Websockets x/net/websocket: Secure Websockets Jul 30, 2015
@mikioh mikioh modified the milestone: Unreleased Jul 30, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.