Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestStackMem needs to be run in isolation to be accurate #8446

Open
randall77 opened this Issue Jul 30, 2014 · 4 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  Unplanned
4 participants
@randall77 @dvyukov @ianlancetaylor @rsc
@randall77
Copy link
Contributor

randall77 commented Jul 30, 2014 

See CL 119330044

TestStackMem measures the amount of stack used, which can change due to other tests
running simultaneously.

We see instances of the amount of stack used going negative.  This bug requests a way of
running this test in isolation so it isn't degraded by other nearby tests.
@dvyukov

This comment has been minimized.

Sign in to view
Copy link
Member

dvyukov commented Jul 31, 2014

Comment 1:

We have crash_test.go:executeTest for this. It runs a program in complete isolation.
@ianlancetaylor

This comment has been minimized.

Sign in to view
Copy link
Contributor

ianlancetaylor commented Jul 31, 2014

Comment 2:

Labels changed: added repo-main, release-go1.4.
@rsc

This comment has been minimized.

Sign in to view
Copy link
Contributor

rsc commented Sep 16, 2014

Comment 3:

Other tests do not run simultaneously by default. This is more likely an accounting
error, probably fixed by now.
@rsc

This comment has been minimized.

Sign in to view
Copy link
Contributor

rsc commented Sep 16, 2014

Comment 4:

Labels changed: added release-none, removed release-go1.4.

Owner changed to @randall77.

Status changed to Accepted.

@randall77 randall77 added accepted labels Sep 16, 2014

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc removed release-none labels Apr 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.