Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/xml: add Decoder.InputOffset method #8484

Closed
rsc opened this Issue Aug 6, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@rsc
Copy link
Contributor

rsc commented Aug 6, 2014

Implementing XML signatures requires using the Decoder to read token by token but be
able to extract the raw XML behind a given CharData. The Decoder returns decoded
CharData - "hello world" and "hello world" and
"<![CDATA[hello world]]>" are all returned as "hello world".
Providing the input offset allows users of Decoder to go back to the original XML to
find the encoded version.

CL 122960043 does this.
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Aug 6, 2014

Comment 1:

CL https://golang.org/cl/122960043 mentions this issue.
@rsc

This comment has been minimized.

Copy link
Contributor Author

rsc commented Aug 6, 2014

Comment 2:

This issue was closed by revision b91aea5.

Status changed to Fixed.

@rsc rsc added fixed labels Aug 6, 2014

@rsc rsc self-assigned this Aug 6, 2014

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015

@rsc rsc removed the release-go1.4 label Apr 14, 2015

@golang golang locked and limited conversation to collaborators Jun 25, 2016

wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018

encoding/xml: add InputOffset method to Decoder
Among other things, this allows users to match the decoded
pieces with the original XML, which can be necessary for
implementing standards like XML signatures.

Fixes golang#8484.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/122960043

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018

encoding/xml: add InputOffset method to Decoder
Among other things, this allows users to match the decoded
pieces with the original XML, which can be necessary for
implementing standards like XML signatures.

Fixes golang#8484.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/122960043

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.